2002-01-09 18:22:46

by Athanasius

Subject: [PATCH] Athlon XP 1600+ and _mmx_memcpy symbol in modules

Hi,
I've just upraded from my old PII-400 system to an Athlon XP 1600+
based system so changed from "Pentium-Pro/Celeron/Pentium-II"
(CONFIG_M686) to "Athlon/Duron/K7" (CONFIG_MK7). In doing so I suddenly
saw a LOT of problems with modules and the symbol _mmx_memcpy being
undefined.

I finally kludged/fixed this by changing line 121 of
arch/i386/kernel/i386_ksyms.c from:

EXPORT_SYMBOL(_mmx_memcpy);

into:

EXPORT_SYMBOL_NOVERS(_mmx_memcpy);

That's on a vanilla 2.4.17 source tree.

Patch:

--- linux-2.4.17/arch/i386/kernel/i386_ksyms.c Tue Nov 13 17:13:20 2001
+++ linux-2.4.17-athlon/arch/i386/kernel/i386_ksyms.c Wed Jan 9 17:32:19 2002
@@ -118,7 +118,7 @@
#endif

#ifdef CONFIG_X86_USE_3DNOW
-EXPORT_SYMBOL(_mmx_memcpy);
+EXPORT_SYMBOL_NOVERS(_mmx_memcpy);
EXPORT_SYMBOL(mmx_clear_page);
EXPORT_SYMBOL(mmx_copy_page);
#endif
--
- Athanasius = Athanasius(at)gurus.tf / http://www.clan-lovely.org/~athan/
Finger athan(at)fysh.org for PGP key
"And it's me who is my enemy. Me who beats me up.
Me who makes the monsters. Me who strips my confidence." Paula Cole - ME

2002-01-09 19:06:39

by Arjan van de Ven

Subject: Re: [PATCH] Athlon XP 1600+ and _mmx_memcpy symbol in modules

In article <[email protected]> you wrote:
> Hi,
> I've just upraded from my old PII-400 system to an Athlon XP 1600+
> based system so changed from "Pentium-Pro/Celeron/Pentium-II"
> (CONFIG_M686) to "Athlon/Duron/K7" (CONFIG_MK7). In doing so I suddenly
> saw a LOT of problems with modules and the symbol _mmx_memcpy being
> undefined.

> I finally kludged/fixed this by changing line 121 of
> arch/i386/kernel/i386_ksyms.c from:

> EXPORT_SYMBOL(_mmx_memcpy);

you forgot to make mrproper ;) (or at least make clean)
yes the makefile for modversions is missing a dependency......

2002-01-09 22:08:41

by Athanasius

Subject: Re: [PATCH] Athlon XP 1600+ and _mmx_memcpy symbol in modules

On Wed, Jan 09, 2002 at 07:05:20PM +0000, [email protected] wrote:
> In article <[email protected]> you wrote:
> > Hi,
> > I've just upraded from my old PII-400 system to an Athlon XP 1600+
> > based system so changed from "Pentium-Pro/Celeron/Pentium-II"
> > (CONFIG_M686) to "Athlon/Duron/K7" (CONFIG_MK7). In doing so I suddenly
> > saw a LOT of problems with modules and the symbol _mmx_memcpy being
> > undefined.
>
> > I finally kludged/fixed this by changing line 121 of
> > arch/i386/kernel/i386_ksyms.c from:
>
> > EXPORT_SYMBOL(_mmx_memcpy);
>
> you forgot to make mrproper ;) (or at least make clean)
> yes the makefile for modversions is missing a dependency......

I'll recheck with 'make mrproper' as I do always do a 'make clean'
(and dep for that matter) after changing configuration at all.

thanks,

-Ath
--
- Athanasius = Athanasius(at)gurus.tf / http://www.clan-lovely.org/~athan/
Finger athan(at)fysh.org for PGP key
"And it's me who is my enemy. Me who beats me up.
Me who makes the monsters. Me who strips my confidence." Paula Cole - ME

2002-01-09 22:34:35

by Athanasius

Subject: Re: [PATCH] Athlon XP 1600+ and _mmx_memcpy symbol in modules

On Wed, Jan 09, 2002 at 10:08:21PM +0000, Athanasius wrote:
> On Wed, Jan 09, 2002 at 07:05:20PM +0000, [email protected] wrote:
> > you forgot to make mrproper ;) (or at least make clean)
> > yes the makefile for modversions is missing a dependency......
>
> I'll recheck with 'make mrproper' as I do always do a 'make clean'
> (and dep for that matter) after changing configuration at all.

Yup, 'make mrproper' followed by the usual steps gives me a thus-far
working kernel and modules.

thanks again,

-Ath
--
- Athanasius = Athanasius(at)gurus.tf / http://www.clan-lovely.org/~athan/
Finger athan(at)fysh.org for PGP key
"And it's me who is my enemy. Me who beats me up.
Me who makes the monsters. Me who strips my confidence." Paula Cole - ME