2002-09-10 18:49:00

by Bob Tracy

[permalink] [raw]
Subject: 2.5.X config: USB speedtouch driver

Minor nit: the subject driver depends on ATM, so a config-time check to
see if ATM support is enabled is appropriate.

--
-----------------------------------------------------------------------
Bob Tracy WTO + WIPO = DMCA? http://www.anti-dmca.org
[email protected]
-----------------------------------------------------------------------


2002-09-10 19:02:42

by Greg KH

[permalink] [raw]
Subject: Re: 2.5.X config: USB speedtouch driver

On Tue, Sep 10, 2002 at 01:53:45PM -0500, Bob_Tracy wrote:
> Minor nit: the subject driver depends on ATM, so a config-time check to
> see if ATM support is enabled is appropriate.

Agreed, patch? :)

greg k-h

2002-09-10 19:41:14

by Bob Tracy

[permalink] [raw]
Subject: Re: 2.5.X config: USB speedtouch driver

Greg KH wrote:
> On Tue, Sep 10, 2002 at 01:53:45PM -0500, Bob_Tracy wrote:
> > Minor nit: the subject driver depends on ATM, so a config-time check to
> > see if ATM support is enabled is appropriate.
>
> Agreed, patch? :)

Ok. You shamed me into it :-). If I understand how dep_tristate works,
the attached one-liner should do the trick. Sorry for doing this as an
attachment, but I've seen my mailer mangle stuff when I try to include
it in-line :-(.

--
-----------------------------------------------------------------------
Bob Tracy WTO + WIPO = DMCA? http://www.anti-dmca.org
[email protected]
-----------------------------------------------------------------------


Attachments:
patch34_usbmisc (640.00 B)

2002-09-12 00:48:34

by Greg KH

[permalink] [raw]
Subject: Re: 2.5.X config: USB speedtouch driver

On Tue, Sep 10, 2002 at 02:44:37PM -0500, Bob_Tracy wrote:
> Greg KH wrote:
> > On Tue, Sep 10, 2002 at 01:53:45PM -0500, Bob_Tracy wrote:
> > > Minor nit: the subject driver depends on ATM, so a config-time check to
> > > see if ATM support is enabled is appropriate.
> >
> > Agreed, patch? :)
>
> Ok. You shamed me into it :-). If I understand how dep_tristate works,
> the attached one-liner should do the trick. Sorry for doing this as an
> attachment, but I've seen my mailer mangle stuff when I try to include
> it in-line :-(.

Looks good, I've applied this to my tree.

thanks,

greg k-h