2001-10-25 05:59:41

by Michal Jaegermann

Subject: old bug in sym53c8xx still lurks in 2.2.20pre

Gerard Roudier posted at the beginning of an April a fix to a queue
handling in that driver which seems to be forgotten. I was looking
through 2.2.20pre and found that the bug is still there.

There are two things about the bug - it may actually hit (some got it
while running cdparanoia) and if you look closer at the original code
you will see that it is quite suspicious. :-)

Here it is again the fix as posted by Gerard re-diffed against
2.2.19something sources. It still applies cleanly to 2.2.20pre11.


--- linux-2.2.19aa2/drivers/scsi/sym53c8xx.c.symx Sun Mar 25 09:31:33 2001
+++ linux-2.2.19aa2/drivers/scsi/sym53c8xx.c Fri Apr 27 10:39:16 2001
@@ -10125,14 +10125,13 @@
if (i >= MAX_START*2)
i = 0;
}
- assert(k != -1);
- if (k != 1) {
+ if (k != -1) {
np->squeue[k] = np->squeue[i]; /* Idle task */
np->squeueput = k; /* Start queue pointer */
- cp->host_status = HS_ABORTED;
- cp->scsi_status = S_ILLEGAL;
- ncr_complete(np, cp);
}
+ cp->host_status = HS_ABORTED;
+ cp->scsi_status = S_ILLEGAL;
+ ncr_complete(np, cp);
}
break;
/*

Hm, I should possibly check the latest 2.4s as well.

Michal

2001-10-27 00:19:37

by Johan Kullstam

Subject: Re: old bug in sym53c8xx still lurks in 2.2.20pre

Michal Jaegermann <[email protected]> writes:

> Gerard Roudier posted at the beginning of an April a fix to a queue
> handling in that driver which seems to be forgotten. I was looking
> through 2.2.20pre and found that the bug is still there.
>
> There are two things about the bug - it may actually hit (some got it
> while running cdparanoia) and if you look closer at the original code
> you will see that it is quite suspicious. :-)
>
> Here it is again the fix as posted by Gerard re-diffed against
> 2.2.19something sources. It still applies cleanly to 2.2.20pre11.
>
>
> --- linux-2.2.19aa2/drivers/scsi/sym53c8xx.c.symx Sun Mar 25 09:31:33 2001
> +++ linux-2.2.19aa2/drivers/scsi/sym53c8xx.c Fri Apr 27 10:39:16 2001
> @@ -10125,14 +10125,13 @@
> if (i >= MAX_START*2)
> i = 0;
> }
> - assert(k != -1);
> - if (k != 1) {
> + if (k != -1) {
> np->squeue[k] = np->squeue[i]; /* Idle task */
> np->squeueput = k; /* Start queue pointer */
> - cp->host_status = HS_ABORTED;
> - cp->scsi_status = S_ILLEGAL;
> - ncr_complete(np, cp);
> }
> + cp->host_status = HS_ABORTED;
> + cp->scsi_status = S_ILLEGAL;
> + ncr_complete(np, cp);
> }
> break;
> /*
>
> Hm, I should possibly check the latest 2.4s as well.

i just checked 2.4.14-pre2 and this patch is in there. i didn't check
on older version or when it arrived so it may be in 2.4.X going way
back.

--
J o h a n K u l l s t a m
[[email protected]]