2011-06-21 09:55:36

by James Hogan

Subject: [PATCH] cb710: fix #ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS

HAVE_EFFICIENT_UNALIGNED_ACCESS is a config option, therefore it needs
the CONFIG_ before it when used by the preprocessor.

Signed-off-by: James Hogan <[email protected]>
---
drivers/misc/cb710/sgbuf2.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/misc/cb710/sgbuf2.c b/drivers/misc/cb710/sgbuf2.c
index d019746..2a40d0e 100644
--- a/drivers/misc/cb710/sgbuf2.c
+++ b/drivers/misc/cb710/sgbuf2.c
@@ -47,7 +47,7 @@ static uint32_t sg_dwiter_read_buffer(struct
sg_mapping_iter *miter)

static inline bool needs_unaligned_copy(const void *ptr)
{
-#ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS
+#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
return false;
#else
return ((ptr - NULL) & 3) != 0;
--
1.7.2.3

2011-06-21 10:17:31

by Michał Mirosław

Subject: Re: [PATCH] cb710: fix #ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS

On Tue, Jun 21, 2011 at 10:55:34AM +0100, James Hogan wrote:
> HAVE_EFFICIENT_UNALIGNED_ACCESS is a config option, therefore it needs
> the CONFIG_ before it when used by the preprocessor.
>
> Signed-off-by: James Hogan <[email protected]>
> ---
> drivers/misc/cb710/sgbuf2.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/misc/cb710/sgbuf2.c b/drivers/misc/cb710/sgbuf2.c
> index d019746..2a40d0e 100644
> --- a/drivers/misc/cb710/sgbuf2.c
> +++ b/drivers/misc/cb710/sgbuf2.c
> @@ -47,7 +47,7 @@ static uint32_t sg_dwiter_read_buffer(struct
> sg_mapping_iter *miter)
>
> static inline bool needs_unaligned_copy(const void *ptr)
> {
> -#ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS
> +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
> return false;
> #else
> return ((ptr - NULL) & 3) != 0;

Acked-by: Micha? Miros?aw <[email protected]>

[Cc: linux-mmc]

2011-06-21 16:15:09

by Chris Ball

Subject: Re: [PATCH] cb710: fix #ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS

Hi,

On Tue, Jun 21 2011, Michał Mirosław wrote:
> On Tue, Jun 21, 2011 at 10:55:34AM +0100, James Hogan wrote:
>> HAVE_EFFICIENT_UNALIGNED_ACCESS is a config option, therefore it needs
>> the CONFIG_ before it when used by the preprocessor.
>>
>> Signed-off-by: James Hogan <[email protected]>
>> ---
>> drivers/misc/cb710/sgbuf2.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/misc/cb710/sgbuf2.c b/drivers/misc/cb710/sgbuf2.c
>> index d019746..2a40d0e 100644
>> --- a/drivers/misc/cb710/sgbuf2.c
>> +++ b/drivers/misc/cb710/sgbuf2.c
>> @@ -47,7 +47,7 @@ static uint32_t sg_dwiter_read_buffer(struct
>> sg_mapping_iter *miter)
>>
>> static inline bool needs_unaligned_copy(const void *ptr)
>> {
>> -#ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS
>> +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
>> return false;
>> #else
>> return ((ptr - NULL) & 3) != 0;
>
> Acked-by: Michał Mirosław <[email protected]>

Thanks, pushed to mmc-next for 3.0.

(James, your patch was corrupt due to a hard line break on the @@
line -- please fix that next time around.)

- Chris.
--
Chris Ball <[email protected]> <http://printf.net/>
One Laptop Per Child

2011-06-21 16:40:57

by James Hogan

Subject: Re: [PATCH] cb710: fix #ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS

Hi,

2011/6/21 Chris Ball <[email protected]>:
> Hi,
>
> On Tue, Jun 21 2011, Michał Mirosław wrote:
>> On Tue, Jun 21, 2011 at 10:55:34AM +0100, James Hogan wrote:
>>> HAVE_EFFICIENT_UNALIGNED_ACCESS is a config option, therefore it needs
>>> the CONFIG_ before it when used by the preprocessor.
>>>
>>> Signed-off-by: James Hogan <[email protected]>
>>> ---
>>>  drivers/misc/cb710/sgbuf2.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/misc/cb710/sgbuf2.c b/drivers/misc/cb710/sgbuf2.c
>>> index d019746..2a40d0e 100644
>>> --- a/drivers/misc/cb710/sgbuf2.c
>>> +++ b/drivers/misc/cb710/sgbuf2.c
>>> @@ -47,7 +47,7 @@ static uint32_t sg_dwiter_read_buffer(struct
>>> sg_mapping_iter *miter)
>>>
>>>  static inline bool needs_unaligned_copy(const void *ptr)
>>>  {
>>> -#ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS
>>> +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
>>>      return false;
>>>  #else
>>>      return ((ptr - NULL) & 3) != 0;
>>
>> Acked-by: Michał Mirosław <[email protected]>
>
> Thanks, pushed to mmc-next for 3.0.
>
> (James, your patch was corrupt due to a hard line break on the @@
> line -- please fix that next time around.)

Ahh, sorry about that Chris, I thought I had that problem sorted!

Thanks
James

>
> - Chris.
> --
> Chris Ball   <[email protected]>   <http://printf.net/>
> One Laptop Per Child
>



--
James Hogan