2010-04-11 05:23:16

by shenghui

Subject: [PATCH] Fix inappropriate substraction on tracing_pages_allocated in trace_free_page()in 2.6.27.y series kernel

I noticed inappropriate substraction on variable
tracing_pages_allocated in trace_free_page()in 2.6.27.y series (from
2.6.27 to 2.6.27.46) kernel.


Signed-off-by: Wang Sheng-Hui <[email protected]>

---
kernel/trace/trace.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 8f3fb3d..dfe3995 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -3018,7 +3018,6 @@ static int trace_free_page(void)
ClearPageLRU(page);
list_del(&page->lru);
tracing_pages_allocated--;
- tracing_pages_allocated--;
__free_page(page);

tracing_reset(data);
@@ -3036,6 +3035,7 @@ static int trace_free_page(void)
page = list_entry(p, struct page, lru);
ClearPageLRU(page);
list_del(&page->lru);
+ tracing_pages_allocated--;
__free_page(page);

tracing_reset(data);

2010-04-19 14:11:34

by Steven Rostedt

Subject: Re: [PATCH] Fix inappropriate substraction on tracing_pages_allocated in trace_free_page()in 2.6.27.y series kernel

On Sun, 2010-04-11 at 13:23 +0800, shenghui wrote:
> I noticed inappropriate substraction on variable
> tracing_pages_allocated in trace_free_page()in 2.6.27.y series (from
> 2.6.27 to 2.6.27.46) kernel.
>

I'm not maintaining a 2.6.27 kernel, but if someone else is, then feel
free to include this.

-- Steve