2024-05-30 12:01:22

by Donald Hunter

[permalink] [raw]
Subject: Re: [PATCH 3/8] netlink: specs: Expand the PSE netlink command with C33 new features

Kory Maincent <[email protected]> writes:

> From: "Kory Maincent (Dent Project)" <[email protected]>
>
> Expand the c33 PSE attributes with PSE class, status message and power
> consumption.
>
> ./ynl/cli.py --spec netlink/specs/ethtool.yaml --no-schema --do pse-get
> --json '{"header":{"dev-name":"eth0"}}'
> {'c33-pse-actual-pw': 1800,
> 'c33-pse-admin-state': 3,
> 'c33-pse-pw-class': 4,
> 'c33-pse-pw-d-status': 4,
> 'c33-pse-pw-status-msg': b'2P Port delivering IEEE.\x00',
> 'header': {'dev-index': 4, 'dev-name': 'eth0'}}
>
> Signed-off-by: Kory Maincent <[email protected]>
> ---
> Documentation/netlink/specs/ethtool.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 00dc61358be8..bb51c293435d 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -922,6 +922,18 @@ attribute-sets:
> name: c33-pse-pw-d-status
> type: u32
> name-prefix: ethtool-a-
> + -
> + name: c33-pse-pw-status-msg
> + type: binary

Shouldn't this be type: string ?

> + name-prefix: ethtool-a-
> + -
> + name: c33-pse-pw-class
> + type: u32
> + name-prefix: ethtool-a-
> + -
> + name: c33-pse-actual-pw
> + type: u32
> + name-prefix: ethtool-a-
> -
> name: rss
> attributes:
> @@ -1611,6 +1623,9 @@ operations:
> - c33-pse-admin-state
> - c33-pse-admin-control
> - c33-pse-pw-d-status
> + - c33-pse-pw-status-msg
> + - c33-pse-pw-class
> + - c33-pse-actual-pw
> dump: *pse-get-op
> -
> name: pse-set