by Andries Brouwer

[permalink] [raw]

Subject: Re: [PATCH 6/8] Extend KD?BENT to handle > 256 keycodes.

On Thu, Sep 25, 2003 at 06:50:12PM +0200, Vojtech Pavlik wrote:

> -struct kbentry {
> +struct kbentry_old {
> unsigned char kb_table;
> unsigned char kb_index;
> unsigned short kb_value;
> };
> +#define KDGKBENT_OLD 0x4B46 /* gets one entry in translation table (old) */
> +#define KDSKBENT_OLD 0x4B47 /* sets one entry in translation table (old) */
> +
> +struct kbentry {
> + unsigned int kb_table;
> + unsigned int kb_index;
> + unsigned short kb_value;
> +};

> -#define KDGKBENT 0x4B46 /* gets one entry in translation table */
> -#define KDSKBENT 0x4B47 /* sets one entry in translation table */
> +#define KDGKBENT 0x4B73 /* gets one entry in translation table */
> +#define KDSKBENT 0x4B74 /* sets one entry in translation table */

Please don't.

As said already, no new ioctls are needed today, but if you add some
anyway, please leave old names unchanged and add something new, like
KDSKBENT32 or so.

Reusing old ioctl names for new uses is very bad practice.

Andries

2003-09-26 05:24:53

On Saturday 27 Sep 2003 22:21, Vojtech Pavlik wrote:
> Yes, exactly so. We may have similar problems with differentiation
> elsewhere (touchpad vs 6dof device), so we'll probably need the 'class'
> field.

I don't know if this is relevant, but there are some devices which can work
in either relative (like a touchpad) or absolute (like a touchscreen) mode.
For example, using a combination of the kernel and the X drivers, at the
moment I have my Wacom tablet working in relative mode when I'm using its
mouse, but absolute mode when I'm using its pen.

I'm wondering whether we don't so much need a device class, as something to
say whether the device works in absolute or relative mode, and that possibly
we might have devices where this could be dynamically changed.

M

--
"It's the small gaps between the rain that count,
and learning how to live amongst them."
-- Jeff Noon

2003-09-28 09:49:15

by Vojtech Pavlik

[permalink] [raw]

Subject: Re: [PATCH 8/8] Add BTN_TOUCH to Synaptics driver. Update mousedev.

On Sat, Sep 27, 2003 at 10:58:05PM +0100, Matt Gibson wrote:
> On Saturday 27 Sep 2003 22:21, Vojtech Pavlik wrote:
> > Yes, exactly so. We may have similar problems with differentiation
> > elsewhere (touchpad vs 6dof device), so we'll probably need the 'class'
> > field.
>
> I don't know if this is relevant, but there are some devices which can work
> in either relative (like a touchpad) or absolute (like a touchscreen) mode.
> For example, using a combination of the kernel and the X drivers, at the
> moment I have my Wacom tablet working in relative mode when I'm using its
> mouse, but absolute mode when I'm using its pen.
>
> I'm wondering whether we don't so much need a device class, as something to
> say whether the device works in absolute or relative mode, and that possibly
> we might have devices where this could be dynamically changed.

That's a pretty neat idea, actually. Thanks!

--
Vojtech Pavlik
SuSE Labs, SuSE CR