2024-02-24 13:55:46

by Chengming Zhou

Subject: [PATCH] usb: isp1760: remove SLAB_MEM_SPREAD flag usage

From: Chengming Zhou <[email protected]>

The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
its usage so we can delete it from slab. No functional change.

Signed-off-by: Chengming Zhou <[email protected]>
---
drivers/usb/isp1760/isp1760-hcd.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.c
index 76862ba40f35..0e5e4cb74c87 100644
--- a/drivers/usb/isp1760/isp1760-hcd.c
+++ b/drivers/usb/isp1760/isp1760-hcd.c
@@ -2521,21 +2521,19 @@ static const struct hc_driver isp1760_hc_driver = {
int __init isp1760_init_kmem_once(void)
{
urb_listitem_cachep = kmem_cache_create("isp1760_urb_listitem",
- sizeof(struct urb_listitem), 0, SLAB_TEMPORARY |
- SLAB_MEM_SPREAD, NULL);
+ sizeof(struct urb_listitem), 0, SLAB_TEMPORARY, NULL);

if (!urb_listitem_cachep)
return -ENOMEM;

qtd_cachep = kmem_cache_create("isp1760_qtd",
- sizeof(struct isp1760_qtd), 0, SLAB_TEMPORARY |
- SLAB_MEM_SPREAD, NULL);
+ sizeof(struct isp1760_qtd), 0, SLAB_TEMPORARY, NULL);

if (!qtd_cachep)
goto destroy_urb_listitem;

qh_cachep = kmem_cache_create("isp1760_qh", sizeof(struct isp1760_qh),
- 0, SLAB_TEMPORARY | SLAB_MEM_SPREAD, NULL);
+ 0, SLAB_TEMPORARY, NULL);

if (!qh_cachep)
goto destroy_qtd;
--
2.40.1

2024-02-26 03:02:49

by Chengming Zhou

Subject: Re: [PATCH] usb: isp1760: remove SLAB_MEM_SPREAD flag usage

On 2024/2/24 21:52, [email protected] wrote:
> From: Chengming Zhou <[email protected]>
>
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.

Update changelog to make it clearer:

The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag since the commit
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
series[1] went on to mark it obsolete to avoid confusion for users.
Here we can just remove all its users, which has no functional change.

[1] https://lore.kernel.org/all/[email protected]/

Thanks!

>
> Signed-off-by: Chengming Zhou <[email protected]>
> ---
> drivers/usb/isp1760/isp1760-hcd.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.c
> index 76862ba40f35..0e5e4cb74c87 100644
> --- a/drivers/usb/isp1760/isp1760-hcd.c
> +++ b/drivers/usb/isp1760/isp1760-hcd.c
> @@ -2521,21 +2521,19 @@ static const struct hc_driver isp1760_hc_driver = {
> int __init isp1760_init_kmem_once(void)
> {
> urb_listitem_cachep = kmem_cache_create("isp1760_urb_listitem",
> - sizeof(struct urb_listitem), 0, SLAB_TEMPORARY |
> - SLAB_MEM_SPREAD, NULL);
> + sizeof(struct urb_listitem), 0, SLAB_TEMPORARY, NULL);
>
> if (!urb_listitem_cachep)
> return -ENOMEM;
>
> qtd_cachep = kmem_cache_create("isp1760_qtd",
> - sizeof(struct isp1760_qtd), 0, SLAB_TEMPORARY |
> - SLAB_MEM_SPREAD, NULL);
> + sizeof(struct isp1760_qtd), 0, SLAB_TEMPORARY, NULL);
>
> if (!qtd_cachep)
> goto destroy_urb_listitem;
>
> qh_cachep = kmem_cache_create("isp1760_qh", sizeof(struct isp1760_qh),
> - 0, SLAB_TEMPORARY | SLAB_MEM_SPREAD, NULL);
> + 0, SLAB_TEMPORARY, NULL);
>
> if (!qh_cachep)
> goto destroy_qtd;

2024-02-26 18:14:19

by Rui Miguel Silva

Subject: Re: [PATCH] usb: isp1760: remove SLAB_MEM_SPREAD flag usage

Hey Zhou,
many thanks for the patch.

Chengming Zhou <[email protected]> writes:

> On 2024/2/24 21:52, [email protected] wrote:
>> From: Chengming Zhou <[email protected]>
>>
>> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
>> its usage so we can delete it from slab. No functional change.
>
> Update changelog to make it clearer:
>
> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
> removed as of v6.8-rc1, so it became a dead flag since the commit
> 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
> series[1] went on to mark it obsolete to avoid confusion for users.
> Here we can just remove all its users, which has no functional change.
>
> [1] https://lore.kernel.org/all/[email protected]/

With this changelog, you can add my tag:
Acked-by: Rui Miguel Silva <[email protected]>

Cheers,
Rui
>
> Thanks!
>
>>
>> Signed-off-by: Chengming Zhou <[email protected]>
>> ---
>> drivers/usb/isp1760/isp1760-hcd.c | 8 +++-----
>> 1 file changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.c
>> index 76862ba40f35..0e5e4cb74c87 100644
>> --- a/drivers/usb/isp1760/isp1760-hcd.c
>> +++ b/drivers/usb/isp1760/isp1760-hcd.c
>> @@ -2521,21 +2521,19 @@ static const struct hc_driver isp1760_hc_driver = {
>> int __init isp1760_init_kmem_once(void)
>> {
>> urb_listitem_cachep = kmem_cache_create("isp1760_urb_listitem",
>> - sizeof(struct urb_listitem), 0, SLAB_TEMPORARY |
>> - SLAB_MEM_SPREAD, NULL);
>> + sizeof(struct urb_listitem), 0, SLAB_TEMPORARY, NULL);
>>
>> if (!urb_listitem_cachep)
>> return -ENOMEM;
>>
>> qtd_cachep = kmem_cache_create("isp1760_qtd",
>> - sizeof(struct isp1760_qtd), 0, SLAB_TEMPORARY |
>> - SLAB_MEM_SPREAD, NULL);
>> + sizeof(struct isp1760_qtd), 0, SLAB_TEMPORARY, NULL);
>>
>> if (!qtd_cachep)
>> goto destroy_urb_listitem;
>>
>> qh_cachep = kmem_cache_create("isp1760_qh", sizeof(struct isp1760_qh),
>> - 0, SLAB_TEMPORARY | SLAB_MEM_SPREAD, NULL);
>> + 0, SLAB_TEMPORARY, NULL);
>>
>> if (!qh_cachep)
>> goto destroy_qtd;

2024-03-05 13:33:29

by Greg Kroah-Hartman

Subject: Re: [PATCH] usb: isp1760: remove SLAB_MEM_SPREAD flag usage

On Mon, Feb 26, 2024 at 11:02:24AM +0800, Chengming Zhou wrote:
> On 2024/2/24 21:52, [email protected] wrote:
> > From: Chengming Zhou <[email protected]>
> >
> > The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> > its usage so we can delete it from slab. No functional change.
>
> Update changelog to make it clearer:
>
> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
> removed as of v6.8-rc1, so it became a dead flag since the commit
> 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
> series[1] went on to mark it obsolete to avoid confusion for users.
> Here we can just remove all its users, which has no functional change.

Please submit a version 2 with this updated changelog.

thanks,

greg k-h