2006-12-27 18:27:06

by Thomas Maier

[permalink] [raw]
Subject: [PATCH 1/1] 2.6.20-rc1-mm1 pktcdvd: cleanup

Hello,

this is a patch to cleanup some things in the pktcdvd driver for linux 2.6.20:

- update documentation
- use clear_bdi_congested/set_bdi_congested functions directly instead of old wrappers
- removed DECLARE_BUF_AS_STRING macro

Signed-off-by: Thomas Maier <[email protected]>

Attachments:
pktcdvd-2.6.20-rc1-mm1.patch (5.08 kB)

2006-12-27 20:45:30

by Phillip Susi

[permalink] [raw]
Subject: Re: [PATCH 1/1] 2.6.20-rc1-mm1 pktcdvd: cleanup

Please attach patches as inline text, not as a binary file, so that we
can all read it.

Thomas Maier wrote:
> Hello,
>
> this is a patch to cleanup some things in the pktcdvd driver for linux 2.6.20:
>
> - update documentation
> - use clear_bdi_congested/set_bdi_congested functions directly instead of old wrappers
> - removed DECLARE_BUF_AS_STRING macro
>
> Signed-off-by: Thomas Maier <[email protected]>

2006-12-28 08:32:28

by Peter Osterlund

[permalink] [raw]
Subject: Re: [PATCH 1/1] 2.6.20-rc1-mm1 pktcdvd: cleanup

"Thomas Maier" <[email protected]> writes:

> this is a patch to cleanup some things in the pktcdvd driver for linux 2.6.20:
>
> - update documentation
> - removed DECLARE_BUF_AS_STRING macro

This part looks good.

> - use clear_bdi_congested/set_bdi_congested functions directly instead of old wrappers

I'm unsure about this one. What's the point of having the
blk_clear_queue_congested()/blk_set_queue_congested() functions if
they are not supposed to be used?

--
Peter Osterlund - [email protected]
http://web.telia.com/~u89404340