On Thu, Aug 14, 2003 at 11:16:27PM +0000, Linux Kernel Mailing List wrote:
> diff -Nru a/drivers/scsi/qla1280.h b/drivers/scsi/qla1280.h
> --- a/drivers/scsi/qla1280.h Mon Aug 18 09:07:03 2003
> +++ b/drivers/scsi/qla1280.h Mon Aug 18 09:07:03 2003
> @@ -1111,7 +1111,11 @@
> /*
> * Linux - SCSI Driver Interface Function Prototypes.
> */
> +#if LINUX_VERSION_CODE < 0x020600
> int qla1280_proc_info(char *, char **, off_t, int, int, int);
> +#else
> +int qla1280_proc_info(struct Scsi_Host *, char *, char **, off_t, int, int);
> +#endif
Since we have people _constantly_ screwing this up (but of course, never
you, Jes :)), please use the KERNEL_VERSION() macro instead of
open-coding the kernel version you are testing. It makes these tests
not only harder to screw up, but easier to read, too.
Jeff
>>>>> "Jeff" == Jeff Garzik <[email protected]> writes:
Jeff> Since we have people _constantly_ screwing this up (but of
Jeff> course, never you, Jes :)), please use the KERNEL_VERSION()
Jeff> macro instead of open-coding the kernel version you are testing.
Jeff> It makes these tests not only harder to screw up, but easier to
Jeff> read, too.
Thats why I used the hex-value and not decimal. Sorry, maybe I am old
fashioned but I always disliked that macro and the hex values are
really easy to read which is why I decided to stick to that.
Cheers,
Jes