From: James Cloos <[email protected]>
Date: Mon, 27 Oct 2008 19:45:58 -0400
> Commit b1ee26bab1 breaks radeonfb on my inspiron 8100 (P3-M with a
> Mobility M7 LW [7500] (1002:4c57 1028:00e6)).
Please quote at least the headerline of the commit so that it can
come into our memory quickly when reading your report.
Here it is for the others:
commit b1ee26bab14886350ba12a5c10cbc0696ac679bf
Author: Benjamin Herrenschmidt <[email protected]>
Date: Wed Oct 15 22:03:46 2008 -0700
radeonfb: accelerate imageblit and other improvements
Implement support for HW color expansion of 1bpp images, along with some
improvements to the FIFO handling and other accel operations.
The offset fixup code is now unnecessary as the fbcon core will call our
set_par upon switch back from KD_GRAPHICS before anything else happens. I
removed it as it would slow down accel operations.
The fifo wait has been improved to avoid hitting the HW register as often,
and the various accel ops are now performing better caching of register
values.
Overall, this improve accel performances. The imageblit acceleration does
result in a small overall regression in performances on some machines (on
the order of 5% on some x86), probably becaus the SW path provides a
better bus utilisation, but I decided to ingnore that as the performances
is still very good, and on the other hand, some machines such as some
sparc64 get a 3 fold performance improvement.
Signed-off-by: Benjamin Herrenschmidt <[email protected]>
Acked-by: David S. Miller <[email protected]>
Cc: Krzysztof Halasa <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
> The boot is OK until init(8) starts; after init outputs its version info
> it calls rc(8), which starts by setting the fb font. At that point any
> kernel with b1ee26bab1 locks hard. The cursor stops flashing, magic
> sysrq stops working and the fan starts up after a few seconds. (I can't
> tell whether it is the CPU or the GPU that heats up.)
>
> If it is relevant, I use a 10x20 font, so the font change means the
> console converts from 200x75, 8x16 to 160x60, 10x20.
The actual key here is that when setfont runs, the framebuffer layer sets
the acceleration options for the framebuffer for the first time to their
final settings.
> The differences between rc2 and rc2+revert are limited
> to some changes in the size of the kernel:
>
> -Memory: 512232k/524200k available (4376k kernel code, 11428k reserved, 1707k data, 320k init, 0k highmem)
> +Memory: 512272k/524200k available (4354k kernel code, 11388k reserved, 1693k data, 316k init, 0k highmem)
That's just all due to the text size change because of the different
acceleration code.
>>>>> "David" == David Miller <[email protected]> writes:
David> Please quote at least the headerline of the commit so that it can
David> come into our memory quickly when reading your report.
Good point.
David> The actual key here is that when setfont runs, the framebuffer
David> layer sets the acceleration options for the framebuffer for the
David> first time to their final settings.
Explains why it breaks. Thanks!
>> -Memory: 512232k/524200k available (4376k kernel code, 11428k reserved, 1707k data, 320k init, 0k highmem)
>> +Memory: 512272k/524200k available (4354k kernel code, 11388k reserved, 1693k data, 316k init, 0k highmem)
David> That's just all due to the text size change because of the
David> different acceleration code.
I left a bit too much unsaid there, but that was the point I was
making. Ie, nothing of issue.
Incidently, it only took 14 hours of compiling to accomplish the
bisect. And that was after a s/=m$/=n/. on my .27 .config.
Anyone bisecting should know that the new HID code is not bisect-safe.
The dell, lg, bright and sony hid drivers all are auto Y if hid is Y and
embedded is N and fail to link (when bisecting) due to missing symbols.
-JimC (still waking up)
--
James Cloos <[email protected]> OpenPGP: 1024D/ED7DAEA6