the check for info is not required as we are checking it immediately
after gx1fb_init_fbinfo() and returnig -ENOMEM if it is NULL.
Signed-off-by: Sudip Mukherjee <[email protected]>
---
drivers/video/fbdev/geode/gx1fb_core.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/geode/gx1fb_core.c b/drivers/video/fbdev/geode/gx1fb_core.c
index 2794ba1..9bee874 100644
--- a/drivers/video/fbdev/geode/gx1fb_core.c
+++ b/drivers/video/fbdev/geode/gx1fb_core.c
@@ -374,10 +374,8 @@ static int gx1fb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
release_mem_region(gx1_gx_base() + 0x8300, 0x100);
}
- if (info) {
- fb_dealloc_cmap(&info->cmap);
- framebuffer_release(info);
- }
+ fb_dealloc_cmap(&info->cmap);
+ framebuffer_release(info);
return ret;
}
--
1.8.1.2
Tomi Valkeinen wrote:
> On 06/01/15 14:45, Sudip Mukherjee wrote:
>> the check for info is not required as we are checking it immediately
>> after gxfb_init_fbinfo() and lxfb_init_fbinfo() and returnig -ENOMEM
>> if it is NULL.
>>
>> Signed-off-by: Sudip Mukherjee <[email protected]>
>> ---
>> Hi Tomi,
>> This patch is similar to my last patch which you have already queued
>> for 3.20. if you can revert that then i can send you a single patch
>> with all these three changes together.
>
> No need for that, two separate patches is fine. So queued for 3.20.
>
> Tomi
Hi sorry for off topic question, but how do you run 3.20 on geode ?
I was not able to boot anything since 2.27 as initrd (I guess udev )
corrupts (I guess memory something) and boot hangs.
One suggested to bisect but no one explained how.
I would be glad to get some hint on how to run kernel with udev support on
geode (means >= 2.27)
thanks
On Sun, 01 Feb 2015 06:05:04 +0100
deloptes <[email protected]> wrote:
> Tomi Valkeinen wrote:
>
> > On 06/01/15 14:45, Sudip Mukherjee wrote:
> >> the check for info is not required as we are checking it immediately
> >> after gxfb_init_fbinfo() and lxfb_init_fbinfo() and returnig -ENOMEM
> >> if it is NULL.
> >>
> >> Signed-off-by: Sudip Mukherjee <[email protected]>
> >> ---
> >> Hi Tomi,
> >> This patch is similar to my last patch which you have already queued
> >> for 3.20. if you can revert that then i can send you a single patch
> >> with all these three changes together.
> >
> > No need for that, two separate patches is fine. So queued for 3.20.
> >
> > Tomi
>
> Hi sorry for off topic question, but how do you run 3.20 on geode ?
> I was not able to boot anything since 2.27 as initrd (I guess udev )
> corrupts (I guess memory something) and boot hangs.
> One suggested to bisect but no one explained how.
> I would be glad to get some hint on how to run kernel with udev support on
> geode (means >= 2.27)
Tinycore has certainly been reported to run on Geode boxes as of 3.x
kernel series. It might be worth trying a tinycore build on the device
just to see how far it gets on your hardware.