2019-03-07 23:59:31

by Joe Perches

Subject: [PATCH] RISC-V: Use IS_ENABLED(CONFIG_CMODEL_MEDLOW)

IS_ENABLED should generally use CONFIG_ prefaced symbols and
it doesn't appear as if there is a CMODEL_MEDLOW define.

Signed-off-by: Joe Perches <[email protected]>
---
arch/riscv/kernel/module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c
index 7dd308129b40..2872edce894d 100644
--- a/arch/riscv/kernel/module.c
+++ b/arch/riscv/kernel/module.c
@@ -141,7 +141,7 @@ static int apply_r_riscv_hi20_rela(struct module *me, u32 *location,
{
s32 hi20;

- if (IS_ENABLED(CMODEL_MEDLOW)) {
+ if (IS_ENABLED(CONFIG_CMODEL_MEDLOW)) {
pr_err(
"%s: target %016llx can not be addressed by the 32-bit offset from PC = %p\n",
me->name, (long long)v, location);

2019-03-08 14:54:24

by Christoph Hellwig

Subject: Re: [PATCH] RISC-V: Use IS_ENABLED(CONFIG_CMODEL_MEDLOW)

On Thu, Mar 07, 2019 at 03:56:34PM -0800, Joe Perches wrote:
> IS_ENABLED should generally use CONFIG_ prefaced symbols and
> it doesn't appear as if there is a CMODEL_MEDLOW define.
>
> Signed-off-by: Joe Perches <[email protected]>

Looks good,

Reviewed-by: Christoph Hellwig <[email protected]>

2019-03-29 07:42:47

by Palmer Dabbelt

Subject: Re: [PATCH] RISC-V: Use IS_ENABLED(CONFIG_CMODEL_MEDLOW)

On Fri, 08 Mar 2019 06:53:02 PST (-0800), Christoph Hellwig wrote:
> On Thu, Mar 07, 2019 at 03:56:34PM -0800, Joe Perches wrote:
>> IS_ENABLED should generally use CONFIG_ prefaced symbols and
>> it doesn't appear as if there is a CMODEL_MEDLOW define.
>>
>> Signed-off-by: Joe Perches <[email protected]>
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <[email protected]>

Thanks. This one is also in the list for the next RC.