Hi Palmer,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 27bba9c532a8d21050b94224ffd310ad0058c353
commit: d5be89a8d118a8e8d09cd74a921a808f17fbdd09 RISC-V: Resurrect the MMIO timer implementation for M-mode systems
date: 9 weeks ago
config: riscv-randconfig-r034-20201121 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bec968cbb367dd03439c89c1d4ef968ef662d7c0)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d5be89a8d118a8e8d09cd74a921a808f17fbdd09
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout d5be89a8d118a8e8d09cd74a921a808f17fbdd09
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
In file included from drivers/clocksource/timer-riscv.c:10:
In file included from include/linux/clocksource.h:21:
In file included from arch/riscv/include/asm/io.h:148:
include/asm-generic/io.h:556:9: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
return inb(addr);
^~~~~~~~~
arch/riscv/include/asm/io.h:54:76: note: expanded from macro 'inb'
#define inb(c) ({ u8 __v; __io_pbr(); __v = readb_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; })
~~~~~~~~~~ ^
arch/riscv/include/asm/mmio.h:87:48: note: expanded from macro 'readb_cpu'
#define readb_cpu(c) ({ u8 __r = __raw_readb(c); __r; })
^
In file included from drivers/clocksource/timer-riscv.c:10:
In file included from include/linux/clocksource.h:21:
In file included from arch/riscv/include/asm/io.h:148:
include/asm-generic/io.h:564:9: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
return inw(addr);
^~~~~~~~~
arch/riscv/include/asm/io.h:55:76: note: expanded from macro 'inw'
#define inw(c) ({ u16 __v; __io_pbr(); __v = readw_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; })
~~~~~~~~~~ ^
arch/riscv/include/asm/mmio.h:88:76: note: expanded from macro 'readw_cpu'
#define readw_cpu(c) ({ u16 __r = le16_to_cpu((__force __le16)__raw_readw(c)); __r; })
^
include/uapi/linux/byteorder/little_endian.h:36:51: note: expanded from macro '__le16_to_cpu'
#define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
^
In file included from drivers/clocksource/timer-riscv.c:10:
In file included from include/linux/clocksource.h:21:
In file included from arch/riscv/include/asm/io.h:148:
include/asm-generic/io.h:572:9: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
return inl(addr);
^~~~~~~~~
arch/riscv/include/asm/io.h:56:76: note: expanded from macro 'inl'
#define inl(c) ({ u32 __v; __io_pbr(); __v = readl_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; })
~~~~~~~~~~ ^
arch/riscv/include/asm/mmio.h:89:76: note: expanded from macro 'readl_cpu'
#define readl_cpu(c) ({ u32 __r = le32_to_cpu((__force __le32)__raw_readl(c)); __r; })
^
include/uapi/linux/byteorder/little_endian.h:34:51: note: expanded from macro '__le32_to_cpu'
#define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
^
In file included from drivers/clocksource/timer-riscv.c:10:
In file included from include/linux/clocksource.h:21:
In file included from arch/riscv/include/asm/io.h:148:
include/asm-generic/io.h:580:2: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
outb(value, addr);
^~~~~~~~~~~~~~~~~
arch/riscv/include/asm/io.h:58:68: note: expanded from macro 'outb'
#define outb(v,c) ({ __io_pbw(); writeb_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); })
~~~~~~~~~~ ^
arch/riscv/include/asm/mmio.h:91:52: note: expanded from macro 'writeb_cpu'
#define writeb_cpu(v, c) ((void)__raw_writeb((v), (c)))
^
In file included from drivers/clocksource/timer-riscv.c:10:
In file included from include/linux/clocksource.h:21:
In file included from arch/riscv/include/asm/io.h:148:
include/asm-generic/io.h:588:2: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
outw(value, addr);
^~~~~~~~~~~~~~~~~
arch/riscv/include/asm/io.h:59:68: note: expanded from macro 'outw'
#define outw(v,c) ({ __io_pbw(); writew_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); })
~~~~~~~~~~ ^
arch/riscv/include/asm/mmio.h:92:76: note: expanded from macro 'writew_cpu'
#define writew_cpu(v, c) ((void)__raw_writew((__force u16)cpu_to_le16(v), (c)))
^
In file included from drivers/clocksource/timer-riscv.c:10:
In file included from include/linux/clocksource.h:21:
In file included from arch/riscv/include/asm/io.h:148:
include/asm-generic/io.h:596:2: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
outl(value, addr);
^~~~~~~~~~~~~~~~~
arch/riscv/include/asm/io.h:60:68: note: expanded from macro 'outl'
#define outl(v,c) ({ __io_pbw(); writel_cpu((v),(void*)(PCI_IOBASE + (c))); __io_paw(); })
~~~~~~~~~~ ^
arch/riscv/include/asm/mmio.h:93:76: note: expanded from macro 'writel_cpu'
#define writel_cpu(v, c) ((void)__raw_writel((__force u32)cpu_to_le32(v), (c)))
^
In file included from drivers/clocksource/timer-riscv.c:10:
In file included from include/linux/clocksource.h:21:
In file included from arch/riscv/include/asm/io.h:148:
include/asm-generic/io.h:1017:55: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE + port;
~~~~~~~~~~ ^
>> drivers/clocksource/timer-riscv.c:28:16: error: implicit declaration of function 'get_cycles64' [-Werror,-Wimplicit-function-declaration]
sbi_set_timer(get_cycles64() + delta);
^
drivers/clocksource/timer-riscv.c:28:16: note: did you mean 'get_cycles'?
arch/riscv/include/asm/timex.h:18:24: note: 'get_cycles' declared here
static inline cycles_t get_cycles(void)
^
drivers/clocksource/timer-riscv.c:47:9: error: implicit declaration of function 'get_cycles64' [-Werror,-Wimplicit-function-declaration]
return get_cycles64();
^
drivers/clocksource/timer-riscv.c:52:9: error: implicit declaration of function 'get_cycles64' [-Werror,-Wimplicit-function-declaration]
return get_cycles64();
^
7 warnings and 3 errors generated.
vim +/get_cycles64 +28 drivers/clocksource/timer-riscv.c
62b0194368147d drivers/clocksource/riscv_timer.c Palmer Dabbelt 2018-08-04 @10 #include <linux/clocksource.h>
62b0194368147d drivers/clocksource/riscv_timer.c Palmer Dabbelt 2018-08-04 11 #include <linux/clockchips.h>
62b0194368147d drivers/clocksource/riscv_timer.c Palmer Dabbelt 2018-08-04 12 #include <linux/cpu.h>
62b0194368147d drivers/clocksource/riscv_timer.c Palmer Dabbelt 2018-08-04 13 #include <linux/delay.h>
62b0194368147d drivers/clocksource/riscv_timer.c Palmer Dabbelt 2018-08-04 14 #include <linux/irq.h>
033a65de7eced8 drivers/clocksource/timer-riscv.c Anup Patel 2020-06-01 15 #include <linux/irqdomain.h>
92e0d143fdef1f drivers/clocksource/riscv_timer.c Anup Patel 2018-12-04 16 #include <linux/sched_clock.h>
4f9bbcefa14286 drivers/clocksource/timer-riscv.c Christoph Hellwig 2019-10-28 17 #include <linux/io-64-nonatomic-lo-hi.h>
033a65de7eced8 drivers/clocksource/timer-riscv.c Anup Patel 2020-06-01 18 #include <linux/interrupt.h>
033a65de7eced8 drivers/clocksource/timer-riscv.c Anup Patel 2020-06-01 19 #include <linux/of_irq.h>
f99fb607fb2bc0 drivers/clocksource/riscv_timer.c Atish Patra 2018-10-02 20 #include <asm/smp.h>
62b0194368147d drivers/clocksource/riscv_timer.c Palmer Dabbelt 2018-08-04 21 #include <asm/sbi.h>
2bc3fc877aa9c4 drivers/clocksource/timer-riscv.c Anup Patel 2020-08-17 22 #include <asm/timex.h>
4f9bbcefa14286 drivers/clocksource/timer-riscv.c Christoph Hellwig 2019-10-28 23
62b0194368147d drivers/clocksource/riscv_timer.c Palmer Dabbelt 2018-08-04 24 static int riscv_clock_next_event(unsigned long delta,
62b0194368147d drivers/clocksource/riscv_timer.c Palmer Dabbelt 2018-08-04 25 struct clock_event_device *ce)
62b0194368147d drivers/clocksource/riscv_timer.c Palmer Dabbelt 2018-08-04 26 {
a4c3733d32a72f drivers/clocksource/timer-riscv.c Christoph Hellwig 2019-10-28 27 csr_set(CSR_IE, IE_TIE);
62b0194368147d drivers/clocksource/riscv_timer.c Palmer Dabbelt 2018-08-04 @28 sbi_set_timer(get_cycles64() + delta);
62b0194368147d drivers/clocksource/riscv_timer.c Palmer Dabbelt 2018-08-04 29 return 0;
62b0194368147d drivers/clocksource/riscv_timer.c Palmer Dabbelt 2018-08-04 30 }
62b0194368147d drivers/clocksource/riscv_timer.c Palmer Dabbelt 2018-08-04 31
:::::: The code at line 28 was first introduced by commit
:::::: 62b0194368147def8c5a77ce604a125d620fc582 clocksource: new RISC-V SBI timer driver
:::::: TO: Palmer Dabbelt <[email protected]>
:::::: CC: Palmer Dabbelt <[email protected]>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
On 11/21/20 6:26 AM, kernel test robot wrote:
> Hi Palmer,
>
> FYI, the error/warning still remains.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 27bba9c532a8d21050b94224ffd310ad0058c353
> commit: d5be89a8d118a8e8d09cd74a921a808f17fbdd09 RISC-V: Resurrect the MMIO timer implementation for M-mode systems
> date: 9 weeks ago
> config: riscv-randconfig-r034-20201121 (attached as .config)
> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bec968cbb367dd03439c89c1d4ef968ef662d7c0)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install riscv cross compiling tool for clang build
> # apt-get install binutils-riscv64-linux-gnu
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d5be89a8d118a8e8d09cd74a921a808f17fbdd09
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout d5be89a8d118a8e8d09cd74a921a808f17fbdd09
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All errors (new ones prefixed by >>):
CONFIG_RISCV_M_MODE=y
and that prevents get_cycles64() in
arch/riscv/include/asm/timex.h from being visible.
I suppose that was intended?
>>> drivers/clocksource/timer-riscv.c:28:16: error: implicit declaration of function 'get_cycles64' [-Werror,-Wimplicit-function-declaration]
> sbi_set_timer(get_cycles64() + delta);
> ^
> drivers/clocksource/timer-riscv.c:28:16: note: did you mean 'get_cycles'?
> arch/riscv/include/asm/timex.h:18:24: note: 'get_cycles' declared here
> static inline cycles_t get_cycles(void)
> ^
> drivers/clocksource/timer-riscv.c:47:9: error: implicit declaration of function 'get_cycles64' [-Werror,-Wimplicit-function-declaration]
> return get_cycles64();
> ^
> drivers/clocksource/timer-riscv.c:52:9: error: implicit declaration of function 'get_cycles64' [-Werror,-Wimplicit-function-declaration]
> return get_cycles64();
> ^
> 7 warnings and 3 errors generated.
>
> vim +/get_cycles64 +28 drivers/clocksource/timer-riscv.c
>
On Tue, 24 Nov 2020 13:13:07 PST (-0800), [email protected] wrote:
> On 11/21/20 6:26 AM, kernel test robot wrote:
>> Hi Palmer,
>>
>> FYI, the error/warning still remains.
>>
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head: 27bba9c532a8d21050b94224ffd310ad0058c353
>> commit: d5be89a8d118a8e8d09cd74a921a808f17fbdd09 RISC-V: Resurrect the MMIO timer implementation for M-mode systems
>> date: 9 weeks ago
>> config: riscv-randconfig-r034-20201121 (attached as .config)
>> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bec968cbb367dd03439c89c1d4ef968ef662d7c0)
>> reproduce (this is a W=1 build):
>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> # install riscv cross compiling tool for clang build
>> # apt-get install binutils-riscv64-linux-gnu
>> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d5be89a8d118a8e8d09cd74a921a808f17fbdd09
>> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>> git fetch --no-tags linus master
>> git checkout d5be89a8d118a8e8d09cd74a921a808f17fbdd09
>> # save the attached .config to linux build tree
>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <[email protected]>
>>
>> All errors (new ones prefixed by >>):
>
> CONFIG_RISCV_M_MODE=y
>
> and that prevents get_cycles64() in
> arch/riscv/include/asm/timex.h from being visible.
>
> I suppose that was intended?
No, I have a fix for it that I'm about to send out. There's also a bit more necessary.
>
>
>>>> drivers/clocksource/timer-riscv.c:28:16: error: implicit declaration of function 'get_cycles64' [-Werror,-Wimplicit-function-declaration]
>> sbi_set_timer(get_cycles64() + delta);
>> ^
>> drivers/clocksource/timer-riscv.c:28:16: note: did you mean 'get_cycles'?
>> arch/riscv/include/asm/timex.h:18:24: note: 'get_cycles' declared here
>> static inline cycles_t get_cycles(void)
>> ^
>> drivers/clocksource/timer-riscv.c:47:9: error: implicit declaration of function 'get_cycles64' [-Werror,-Wimplicit-function-declaration]
>> return get_cycles64();
>> ^
>> drivers/clocksource/timer-riscv.c:52:9: error: implicit declaration of function 'get_cycles64' [-Werror,-Wimplicit-function-declaration]
>> return get_cycles64();
>> ^
>> 7 warnings and 3 errors generated.
>>
>> vim +/get_cycles64 +28 drivers/clocksource/timer-riscv.c
>>