2021-05-30 04:55:40

by Guo Ren

Subject: [PATCH V2 0/2] arch: Cleanup unused functions

From: Guo Ren <[email protected]>

These functions haven't been used, so just remove them. The patch
has been tested with riscv, but I only use grep to check the
microblaze's.

Changes since v1:
- Separate into two patches
- Add Reviewed-by & Acked-by

Guo Ren (2):
riscv: Cleanup unused functions
microblaze: Cleanup unused functions

arch/microblaze/include/asm/page.h | 3 ---
arch/riscv/include/asm/page.h | 10 ----------
2 files changed, 13 deletions(-)

--
2.7.4

2021-05-30 04:56:21

by Guo Ren

Subject: [PATCH V2 1/2] riscv: Cleanup unused functions

From: Guo Ren <[email protected]>

These functions haven't been used, so just remove them. The patch
has been tested with riscv.

Signed-off-by: Guo Ren <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
Reviewed-by: Anup Patel <[email protected]>
Reviewed-by: Palmer Dabbelt <[email protected]>
Acked-by: Palmer Dabbelt <[email protected]>
---
arch/riscv/include/asm/page.h | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/arch/riscv/include/asm/page.h b/arch/riscv/include/asm/page.h
index 6a7761c..a1b888f 100644
--- a/arch/riscv/include/asm/page.h
+++ b/arch/riscv/include/asm/page.h
@@ -37,16 +37,6 @@

#ifndef __ASSEMBLY__

-#define PAGE_UP(addr) (((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1)))
-#define PAGE_DOWN(addr) ((addr)&(~((PAGE_SIZE)-1)))
-
-/* align addr on a size boundary - adjust address up/down if needed */
-#define _ALIGN_UP(addr, size) (((addr)+((size)-1))&(~((size)-1)))
-#define _ALIGN_DOWN(addr, size) ((addr)&(~((size)-1)))
-
-/* align addr on a size boundary - adjust address up if needed */
-#define _ALIGN(addr, size) _ALIGN_UP(addr, size)
-
#define clear_page(pgaddr) memset((pgaddr), 0, PAGE_SIZE)
#define copy_page(to, from) memcpy((to), (from), PAGE_SIZE)

--
2.7.4

2021-05-30 04:58:48

by Guo Ren

Subject: [PATCH V2 2/2] microblaze: Cleanup unused functions

From: Guo Ren <[email protected]>

These functions haven't been used, so just remove them. The patch
just uses grep to verify.

Signed-off-by: Guo Ren <[email protected]>
Reviewed-by: Anup Patel <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
Reviewed-by: Palmer Dabbelt <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Michal Simek <[email protected]>
---
arch/microblaze/include/asm/page.h | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/microblaze/include/asm/page.h b/arch/microblaze/include/asm/page.h
index bf681f2..ce55097 100644
--- a/arch/microblaze/include/asm/page.h
+++ b/arch/microblaze/include/asm/page.h
@@ -35,9 +35,6 @@

#define ARCH_SLAB_MINALIGN L1_CACHE_BYTES

-#define PAGE_UP(addr) (((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1)))
-#define PAGE_DOWN(addr) ((addr)&(~((PAGE_SIZE)-1)))
-
/*
* PAGE_OFFSET -- the first address of the first page of memory. With MMU
* it is set to the kernel start address (aligned on a page boundary).
--
2.7.4

2021-05-31 12:26:46

by Michal Simek

Subject: Re: [PATCH V2 2/2] microblaze: Cleanup unused functions

On 5/30/21 6:53 AM, [email protected] wrote:
> From: Guo Ren <[email protected]>
>
> These functions haven't been used, so just remove them. The patch
> just uses grep to verify.
>
> Signed-off-by: Guo Ren <[email protected]>
> Reviewed-by: Anup Patel <[email protected]>
> Reviewed-by: Christoph Hellwig <[email protected]>
> Reviewed-by: Palmer Dabbelt <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Michal Simek <[email protected]>
> ---
> arch/microblaze/include/asm/page.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/microblaze/include/asm/page.h b/arch/microblaze/include/asm/page.h
> index bf681f2..ce55097 100644
> --- a/arch/microblaze/include/asm/page.h
> +++ b/arch/microblaze/include/asm/page.h
> @@ -35,9 +35,6 @@
>
> #define ARCH_SLAB_MINALIGN L1_CACHE_BYTES
>
> -#define PAGE_UP(addr) (((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1)))
> -#define PAGE_DOWN(addr) ((addr)&(~((PAGE_SIZE)-1)))
> -
> /*
> * PAGE_OFFSET -- the first address of the first page of memory. With MMU
> * it is set to the kernel start address (aligned on a page boundary).
>

Ah ok. you have sent v2. Will take this version instead of previous one.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs

2021-05-31 12:36:30

by Guo Ren

Subject: Re: [PATCH V2 2/2] microblaze: Cleanup unused functions

On Mon, May 31, 2021 at 8:25 PM Michal Simek <[email protected]> wrote:
>
>
>
> On 5/30/21 6:53 AM, [email protected] wrote:
> > From: Guo Ren <[email protected]>
> >
> > These functions haven't been used, so just remove them. The patch
> > just uses grep to verify.
> >
> > Signed-off-by: Guo Ren <[email protected]>
> > Reviewed-by: Anup Patel <[email protected]>
> > Reviewed-by: Christoph Hellwig <[email protected]>
> > Reviewed-by: Palmer Dabbelt <[email protected]>
> > Cc: Arnd Bergmann <[email protected]>
> > Cc: Michal Simek <[email protected]>
> > ---
> > arch/microblaze/include/asm/page.h | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/arch/microblaze/include/asm/page.h b/arch/microblaze/include/asm/page.h
> > index bf681f2..ce55097 100644
> > --- a/arch/microblaze/include/asm/page.h
> > +++ b/arch/microblaze/include/asm/page.h
> > @@ -35,9 +35,6 @@
> >
> > #define ARCH_SLAB_MINALIGN L1_CACHE_BYTES
> >
> > -#define PAGE_UP(addr) (((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1)))
> > -#define PAGE_DOWN(addr) ((addr)&(~((PAGE_SIZE)-1)))
> > -
> > /*
> > * PAGE_OFFSET -- the first address of the first page of memory. With MMU
> > * it is set to the kernel start address (aligned on a page boundary).
> >
>
> Ah ok. you have sent v2. Will take this version instead of previous one.
No need, they are the same, Thx.

>
> Thanks,
> Michal
>
> --
> Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
> w: http://www.monstr.eu p: +42-0-721842854
> Maintainer of Linux kernel - Xilinx Microblaze
> Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
> U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
>


--
Best Regards
Guo Ren

ML: https://lore.kernel.org/linux-csky/

2021-06-09 17:01:10

by Palmer Dabbelt

Subject: Re: [PATCH V2 1/2] riscv: Cleanup unused functions

On Sat, 29 May 2021 21:53:27 PDT (-0700), [email protected] wrote:
> From: Guo Ren <[email protected]>
>
> These functions haven't been used, so just remove them. The patch
> has been tested with riscv.
>
> Signed-off-by: Guo Ren <[email protected]>
> Reviewed-by: Christoph Hellwig <[email protected]>
> Reviewed-by: Anup Patel <[email protected]>
> Reviewed-by: Palmer Dabbelt <[email protected]>
> Acked-by: Palmer Dabbelt <[email protected]>
> ---
> arch/riscv/include/asm/page.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/riscv/include/asm/page.h b/arch/riscv/include/asm/page.h
> index 6a7761c..a1b888f 100644
> --- a/arch/riscv/include/asm/page.h
> +++ b/arch/riscv/include/asm/page.h
> @@ -37,16 +37,6 @@
>
> #ifndef __ASSEMBLY__
>
> -#define PAGE_UP(addr) (((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1)))
> -#define PAGE_DOWN(addr) ((addr)&(~((PAGE_SIZE)-1)))
> -
> -/* align addr on a size boundary - adjust address up/down if needed */
> -#define _ALIGN_UP(addr, size) (((addr)+((size)-1))&(~((size)-1)))
> -#define _ALIGN_DOWN(addr, size) ((addr)&(~((size)-1)))
> -
> -/* align addr on a size boundary - adjust address up if needed */
> -#define _ALIGN(addr, size) _ALIGN_UP(addr, size)
> -
> #define clear_page(pgaddr) memset((pgaddr), 0, PAGE_SIZE)
> #define copy_page(to, from) memcpy((to), (from), PAGE_SIZE)

Thanks, this is on for-next. I'm assuming you want the other one to go
through the microblaze tree, and it looks like it's already been picked
up.