2017-06-06 23:33:49

by Colin King

[permalink] [raw]
Subject: [PATCH] cifs: remove redundant return in cifs_creation_time_get

From: Colin Ian King <[email protected]>

There is a redundant return in function cifs_creation_time_get
that appears to be old vestigial code than can be removed. So
remove it.

Detected by CoverityScan, CID#1361924 ("Structurally dead code")

Signed-off-by: Colin Ian King <[email protected]>
---
fs/cifs/xattr.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/cifs/xattr.c b/fs/cifs/xattr.c
index 3cb5c9e2d4e7..de50e749ff05 100644
--- a/fs/cifs/xattr.c
+++ b/fs/cifs/xattr.c
@@ -188,8 +188,6 @@ static int cifs_creation_time_get(struct dentry *dentry, struct inode *inode,
pcreatetime = (__u64 *)value;
*pcreatetime = CIFS_I(inode)->createtime;
return sizeof(__u64);
-
- return rc;
}


--
2.11.0


2017-06-07 13:00:12

by Aurélien Aptel

[permalink] [raw]
Subject: Re: [PATCH] cifs: remove redundant return in cifs_creation_time_get


Looks good to me.

--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

2017-06-21 16:59:42

by Steve French

[permalink] [raw]
Subject: Re: [PATCH] cifs: remove redundant return in cifs_creation_time_get

merged into cifs-2.6.git for-next

On Wed, Jun 7, 2017 at 8:00 AM, Aurélien Aptel <[email protected]> wrote:
>
> Looks good to me.
>
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
> SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html



--
Thanks,

Steve