This patch series primarily adds QEMU Virt machine kconfig opiton and
does related RV32/RV64 defconfig updates.
This series can be found in riscv_soc_virt_v1 branch at:
https//github.com/avpatel/linux.git
Anup Patel (4):
RISC-V: Add kconfig option for QEMU virt machine
RISC-V: Enable QEMU virt machine support in defconfigs
RISC-V: Select SYSCON Reboot and Poweroff for QEMU virt machine
RISC-V: Select Goldfish RTC driver for QEMU virt machine
arch/riscv/Kconfig.socs | 24 ++++++++++++++++++++++++
arch/riscv/configs/defconfig | 17 +++--------------
arch/riscv/configs/rv32_defconfig | 18 +++---------------
3 files changed, 30 insertions(+), 29 deletions(-)
--
2.17.1
We add kconfig option for QEMU virt machine and select all
required VIRTIO drivers using this kconfig option.
Signed-off-by: Anup Patel <[email protected]>
---
arch/riscv/Kconfig.socs | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
index 536c0ef4aee8..62383951bf2e 100644
--- a/arch/riscv/Kconfig.socs
+++ b/arch/riscv/Kconfig.socs
@@ -10,4 +10,24 @@ config SOC_SIFIVE
help
This enables support for SiFive SoC platform hardware.
+config SOC_VIRT
+ bool "QEMU Virt Machine"
+ select VIRTIO_PCI
+ select VIRTIO_BALLOON
+ select VIRTIO_MMIO
+ select VIRTIO_CONSOLE
+ select VIRTIO_NET
+ select NET_9P_VIRTIO
+ select VIRTIO_BLK
+ select SCSI_VIRTIO
+ select DRM_VIRTIO_GPU
+ select HW_RANDOM_VIRTIO
+ select RPMSG_CHAR
+ select RPMSG_VIRTIO
+ select CRYPTO_DEV_VIRTIO
+ select VIRTIO_INPUT
+ select SIFIVE_PLIC
+ help
+ This enables support for QEMU Virt Machine.
+
endmenu
--
2.17.1
On Mon, 2019-11-25 at 13:22 +0000, Anup Patel wrote:
> We add kconfig option for QEMU virt machine and select all
> required VIRTIO drivers using this kconfig option.
>
> Signed-off-by: Anup Patel <[email protected]>
> ---
> arch/riscv/Kconfig.socs | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> index 536c0ef4aee8..62383951bf2e 100644
> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs
> @@ -10,4 +10,24 @@ config SOC_SIFIVE
> help
> This enables support for SiFive SoC platform hardware.
>
> +config SOC_VIRT
> + bool "QEMU Virt Machine"
> + select VIRTIO_PCI
> + select VIRTIO_BALLOON
> + select VIRTIO_MMIO
> + select VIRTIO_CONSOLE
> + select VIRTIO_NET
> + select NET_9P_VIRTIO
> + select VIRTIO_BLK
> + select SCSI_VIRTIO
> + select DRM_VIRTIO_GPU
> + select HW_RANDOM_VIRTIO
> + select RPMSG_CHAR
> + select RPMSG_VIRTIO
> + select CRYPTO_DEV_VIRTIO
> + select VIRTIO_INPUT
> + select SIFIVE_PLIC
> + help
> + This enables support for QEMU Virt Machine.
> +
> endmenu
Looks good.
Reviewed-by: Atish Patra <[email protected]>
--
Regards,
Atish
On Mon, 25 Nov 2019 05:22:23 PST (-0800), Anup Patel wrote:
> We add kconfig option for QEMU virt machine and select all
> required VIRTIO drivers using this kconfig option.
>
> Signed-off-by: Anup Patel <[email protected]>
> ---
> arch/riscv/Kconfig.socs | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> index 536c0ef4aee8..62383951bf2e 100644
> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs
> @@ -10,4 +10,24 @@ config SOC_SIFIVE
> help
> This enables support for SiFive SoC platform hardware.
>
> +config SOC_VIRT
> + bool "QEMU Virt Machine"
> + select VIRTIO_PCI
> + select VIRTIO_BALLOON
> + select VIRTIO_MMIO
> + select VIRTIO_CONSOLE
> + select VIRTIO_NET
> + select NET_9P_VIRTIO
> + select VIRTIO_BLK
> + select SCSI_VIRTIO
> + select DRM_VIRTIO_GPU
> + select HW_RANDOM_VIRTIO
> + select RPMSG_CHAR
> + select RPMSG_VIRTIO
> + select CRYPTO_DEV_VIRTIO
> + select VIRTIO_INPUT
> + select SIFIVE_PLIC
> + help
> + This enables support for QEMU Virt Machine.
> +
> endmenu
Reviewed-by: Palmer Dabbelt <[email protected]>
On Mon, 25 Nov 2019 05:22:13 PST (-0800), Anup Patel wrote:
> This patch series primarily adds QEMU Virt machine kconfig opiton and
> does related RV32/RV64 defconfig updates.
>
> This series can be found in riscv_soc_virt_v1 branch at:
> https//github.com/avpatel/linux.git
>
> Anup Patel (4):
> RISC-V: Add kconfig option for QEMU virt machine
> RISC-V: Enable QEMU virt machine support in defconfigs
> RISC-V: Select SYSCON Reboot and Poweroff for QEMU virt machine
> RISC-V: Select Goldfish RTC driver for QEMU virt machine
>
> arch/riscv/Kconfig.socs | 24 ++++++++++++++++++++++++
> arch/riscv/configs/defconfig | 17 +++--------------
> arch/riscv/configs/rv32_defconfig | 18 +++---------------
> 3 files changed, 30 insertions(+), 29 deletions(-)
Thanks.
LMK if you're going to spin a v2 with the updated commit message.
On Tue, Dec 3, 2019 at 5:02 AM Palmer Dabbelt <[email protected]> wrote:
>
> On Mon, 25 Nov 2019 05:22:13 PST (-0800), Anup Patel wrote:
> > This patch series primarily adds QEMU Virt machine kconfig opiton and
> > does related RV32/RV64 defconfig updates.
> >
> > This series can be found in riscv_soc_virt_v1 branch at:
> > https//github.com/avpatel/linux.git
> >
> > Anup Patel (4):
> > RISC-V: Add kconfig option for QEMU virt machine
> > RISC-V: Enable QEMU virt machine support in defconfigs
> > RISC-V: Select SYSCON Reboot and Poweroff for QEMU virt machine
> > RISC-V: Select Goldfish RTC driver for QEMU virt machine
> >
> > arch/riscv/Kconfig.socs | 24 ++++++++++++++++++++++++
> > arch/riscv/configs/defconfig | 17 +++--------------
> > arch/riscv/configs/rv32_defconfig | 18 +++---------------
> > 3 files changed, 30 insertions(+), 29 deletions(-)
>
> Thanks.
>
> LMK if you're going to spin a v2 with the updated commit message.
There are some conflicts for Linux-5.5-rcX. I will rebase this series and
also update commit message.
Regards,
Anup
WARNING: unmet direct dependencies detected for DRM_VIRTIO_GPU
Depends on [m]: HAS_IOMEM [=y] && DRM [=m] && VIRTIO [=y] && MMU [=y]
Selected by [y]:
- SOC_VIRT [=y]
WARNING: unmet direct dependencies detected for NET_9P_VIRTIO
Depends on [m]: NET [=y] && NET_9P [=m] && VIRTIO [=y]
Selected by [y]:
- SOC_VIRT [=y]
Andreas.
--
Andreas Schwab, SUSE Labs, [email protected]
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
> -----Original Message-----
> From: Andreas Schwab <[email protected]>
> Sent: 09 March 2020 15:42
> To: Anup Patel <[email protected]>
> Cc: Palmer Dabbelt <[email protected]>; Paul Walmsley
> <[email protected]>; Albert Ou <[email protected]>; Atish
> Patra <[email protected]>; Alistair Francis <[email protected]>;
> Christoph Hellwig <[email protected]>; Anup Patel <[email protected]>; linux-
> [email protected]; [email protected]
> Subject: Re: [PATCH 1/4] RISC-V: Add kconfig option for QEMU virt machine
>
> WARNING: unmet direct dependencies detected for DRM_VIRTIO_GPU
> Depends on [m]: HAS_IOMEM [=y] && DRM [=m] && VIRTIO [=y] && MMU
> [=y]
> Selected by [y]:
> - SOC_VIRT [=y]
>
> WARNING: unmet direct dependencies detected for NET_9P_VIRTIO
> Depends on [m]: NET [=y] && NET_9P [=m] && VIRTIO [=y]
> Selected by [y]:
> - SOC_VIRT [=y]
We don't see this warning with rv32_defconfig and defconfig.
Perhaps selecting DRM and NET_9P from SOC_VIRT will help. Can you
try and send patch ?
Regards,
Anup
On Mär 09 2020, Anup Patel wrote:
> Perhaps selecting DRM and NET_9P from SOC_VIRT will help. Can you
> try and send patch ?
No, the config option should be removed. It is useless.
Andreas.
--
Andreas Schwab, SUSE Labs, [email protected]
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
On Tue, Mar 10, 2020 at 3:51 PM Andreas Schwab <[email protected]> wrote:
>
> On Mär 09 2020, Anup Patel wrote:
>
> > Perhaps selecting DRM and NET_9P from SOC_VIRT will help. Can you
> > try and send patch ?
>
> No, the config option should be removed. It is useless.
It's not useless. Going forward, we are adding SOC kconfig option for
each supported platform.
In case of SOC_VIRT, we over-selected all required VIRTIO drivers.
Instead, we should only select essential drivers from SOC_VIRT and
enable the rest of drivers via defconfigs.
Regards,
Anup