2023-08-07 20:01:07

by Bartosz Golaszewski

Subject: [PATCH 6/9] arm64: dts: qcom: sa8775p-ride: index the first SGMII PHY

From: Bartosz Golaszewski <[email protected]>

We'll be adding a second SGMII PHY on the same MDIO bus, so let's index
the first one for better readability.

Signed-off-by: Bartosz Golaszewski <[email protected]>
---
arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
index 1c471278d441..55feaac7fa1b 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
+++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
@@ -263,7 +263,7 @@ vreg_l8e: ldo8 {

&ethernet0 {
phy-mode = "sgmii";
- phy-handle = <&sgmii_phy>;
+ phy-handle = <&sgmii_phy0>;

pinctrl-0 = <&ethernet0_default>;
pinctrl-names = "default";
@@ -279,7 +279,7 @@ mdio {
#address-cells = <1>;
#size-cells = <0>;

- sgmii_phy: phy@8 {
+ sgmii_phy0: phy@8 {
compatible = "ethernet-phy-id0141.0dd4";
reg = <0x8>;
device_type = "ethernet-phy";
--
2.39.2

2023-08-07 22:39:54

by Andrew Halaney

Subject: Re: [PATCH 6/9] arm64: dts: qcom: sa8775p-ride: index the first SGMII PHY

On Mon, Aug 07, 2023 at 09:35:04PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> We'll be adding a second SGMII PHY on the same MDIO bus, so let's index
> the first one for better readability.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>

Reviewed-by: Andrew Halaney <[email protected]>

> ---
> arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> index 1c471278d441..55feaac7fa1b 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> @@ -263,7 +263,7 @@ vreg_l8e: ldo8 {
>
> &ethernet0 {
> phy-mode = "sgmii";
> - phy-handle = <&sgmii_phy>;
> + phy-handle = <&sgmii_phy0>;
>
> pinctrl-0 = <&ethernet0_default>;
> pinctrl-names = "default";
> @@ -279,7 +279,7 @@ mdio {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - sgmii_phy: phy@8 {
> + sgmii_phy0: phy@8 {
> compatible = "ethernet-phy-id0141.0dd4";
> reg = <0x8>;
> device_type = "ethernet-phy";
> --
> 2.39.2
>