After commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
detection more robust"), fw_devlink prints an error when consumer
devices don't have their fwnode set. This used to be ignored silently.
Set the fwnode mipi_dsi_device so fw_devlink can find them and properly
track their dependencies.
This fixes errors like this:
[ 0.334054] nwl-dsi 30a00000.mipi-dsi: Failed to create device link with regulator-lcd-1v8
[ 0.346964] nwl-dsi 30a00000.mipi-dsi: Failed to create device link with backlight-dsi
Reported-by: Martin Kepplinger <[email protected]>
Link: https://lore.kernel.org/lkml/[email protected]/
Fixes: 068a00233969 ("drm: Add MIPI DSI bus support")
Signed-off-by: Saravana Kannan <[email protected]>
---
drivers/gpu/drm/drm_mipi_dsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
index b41aaf2bb9f1..7923cc21b78e 100644
--- a/drivers/gpu/drm/drm_mipi_dsi.c
+++ b/drivers/gpu/drm/drm_mipi_dsi.c
@@ -221,7 +221,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host,
return dsi;
}
- dsi->dev.of_node = info->node;
+ device_set_node(&dsi->dev, of_fwnode_handle(info->node));
dsi->channel = info->channel;
strlcpy(dsi->name, info->type, sizeof(dsi->name));
--
2.40.0.rc1.284.g88254d51c5-goog
Am Donnerstag, dem 09.03.2023 um 22:39 -0800 schrieb Saravana Kannan:
> After commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
> detection more robust"), fw_devlink prints an error when consumer
> devices don't have their fwnode set. This used to be ignored
> silently.
>
> Set the fwnode mipi_dsi_device so fw_devlink can find them and
> properly
> track their dependencies.
>
> This fixes errors like this:
> [ 0.334054] nwl-dsi 30a00000.mipi-dsi: Failed to create device
> link with regulator-lcd-1v8
> [ 0.346964] nwl-dsi 30a00000.mipi-dsi: Failed to create device
> link with backlight-dsi
>
> Reported-by: Martin Kepplinger <[email protected]>
Reported-and-tested-by: Martin Kepplinger <[email protected]>
thanks,
martin
> Link:
> https://lore.kernel.org/lkml/[email protected]/
> Fixes: 068a00233969 ("drm: Add MIPI DSI bus support")
> Signed-off-by: Saravana Kannan <[email protected]>
> ---
> drivers/gpu/drm/drm_mipi_dsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_mipi_dsi.c
> b/drivers/gpu/drm/drm_mipi_dsi.c
> index b41aaf2bb9f1..7923cc21b78e 100644
> --- a/drivers/gpu/drm/drm_mipi_dsi.c
> +++ b/drivers/gpu/drm/drm_mipi_dsi.c
> @@ -221,7 +221,7 @@ mipi_dsi_device_register_full(struct
> mipi_dsi_host *host,
> return dsi;
> }
>
> - dsi->dev.of_node = info->node;
> + device_set_node(&dsi->dev, of_fwnode_handle(info->node));
> dsi->channel = info->channel;
> strlcpy(dsi->name, info->type, sizeof(dsi->name));
>
On Sun, Mar 12, 2023 at 7:45 AM Martin Kepplinger
<[email protected]> wrote:
>
> Am Donnerstag, dem 09.03.2023 um 22:39 -0800 schrieb Saravana Kannan:
> > After commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
> > detection more robust"), fw_devlink prints an error when consumer
> > devices don't have their fwnode set. This used to be ignored
> > silently.
> >
> > Set the fwnode mipi_dsi_device so fw_devlink can find them and
> > properly
> > track their dependencies.
> >
> > This fixes errors like this:
> > [ 0.334054] nwl-dsi 30a00000.mipi-dsi: Failed to create device
> > link with regulator-lcd-1v8
> > [ 0.346964] nwl-dsi 30a00000.mipi-dsi: Failed to create device
> > link with backlight-dsi
> >
> > Reported-by: Martin Kepplinger <[email protected]>
>
> Reported-and-tested-by: Martin Kepplinger <[email protected]>
Maintainers,
Nudge nudge. Will this be picked up for 6.3-rcX?
-Saravana
>
> thanks,
> martin
>
> > Link:
> > https://lore.kernel.org/lkml/[email protected]/
> > Fixes: 068a00233969 ("drm: Add MIPI DSI bus support")
> > Signed-off-by: Saravana Kannan <[email protected]>
> > ---
> > drivers/gpu/drm/drm_mipi_dsi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c
> > b/drivers/gpu/drm/drm_mipi_dsi.c
> > index b41aaf2bb9f1..7923cc21b78e 100644
> > --- a/drivers/gpu/drm/drm_mipi_dsi.c
> > +++ b/drivers/gpu/drm/drm_mipi_dsi.c
> > @@ -221,7 +221,7 @@ mipi_dsi_device_register_full(struct
> > mipi_dsi_host *host,
> > return dsi;
> > }
> >
> > - dsi->dev.of_node = info->node;
> > + device_set_node(&dsi->dev, of_fwnode_handle(info->node));
> > dsi->channel = info->channel;
> > strlcpy(dsi->name, info->type, sizeof(dsi->name));
> >
>
>
> --
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
>
On Fri, Mar 17, 2023 at 3:36 PM Saravana Kannan <[email protected]> wrote:
>
> On Sun, Mar 12, 2023 at 7:45 AM Martin Kepplinger
> <[email protected]> wrote:
> >
> > Am Donnerstag, dem 09.03.2023 um 22:39 -0800 schrieb Saravana Kannan:
> > > After commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
> > > detection more robust"), fw_devlink prints an error when consumer
> > > devices don't have their fwnode set. This used to be ignored
> > > silently.
> > >
> > > Set the fwnode mipi_dsi_device so fw_devlink can find them and
> > > properly
> > > track their dependencies.
> > >
> > > This fixes errors like this:
> > > [ 0.334054] nwl-dsi 30a00000.mipi-dsi: Failed to create device
> > > link with regulator-lcd-1v8
> > > [ 0.346964] nwl-dsi 30a00000.mipi-dsi: Failed to create device
> > > link with backlight-dsi
> > >
> > > Reported-by: Martin Kepplinger <[email protected]>
> >
> > Reported-and-tested-by: Martin Kepplinger <[email protected]>
>
> Maintainers,
>
> Nudge nudge. Will this be picked up for 6.3-rcX?
Greg,
Can you pick this up please? It's a fix that hasn't been picked up for
a few months.
Here's the link to the actual patch for your convenience:
https://lore.kernel.org/lkml/[email protected]/#t
-Saravana
>
> -Saravana
>
> >
> > thanks,
> > martin
> >
> > > Link:
> > > https://lore.kernel.org/lkml/[email protected]/
> > > Fixes: 068a00233969 ("drm: Add MIPI DSI bus support")
> > > Signed-off-by: Saravana Kannan <[email protected]>
> > > ---
> > > drivers/gpu/drm/drm_mipi_dsi.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c
> > > b/drivers/gpu/drm/drm_mipi_dsi.c
> > > index b41aaf2bb9f1..7923cc21b78e 100644
> > > --- a/drivers/gpu/drm/drm_mipi_dsi.c
> > > +++ b/drivers/gpu/drm/drm_mipi_dsi.c
> > > @@ -221,7 +221,7 @@ mipi_dsi_device_register_full(struct
> > > mipi_dsi_host *host,
> > > return dsi;
> > > }
> > >
> > > - dsi->dev.of_node = info->node;
> > > + device_set_node(&dsi->dev, of_fwnode_handle(info->node));
> > > dsi->channel = info->channel;
> > > strlcpy(dsi->name, info->type, sizeof(dsi->name));
> > >
> >
> >
> > --
> > To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> >
Hi Saravana,
On Wed, May 03, 2023 at 09:40:05PM -0700, Saravana Kannan wrote:
> On Fri, Mar 17, 2023 at 3:36 PM Saravana Kannan <[email protected]> wrote:
> >
> > On Sun, Mar 12, 2023 at 7:45 AM Martin Kepplinger
> > <[email protected]> wrote:
> > >
> > > Am Donnerstag, dem 09.03.2023 um 22:39 -0800 schrieb Saravana Kannan:
> > > > After commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
> > > > detection more robust"), fw_devlink prints an error when consumer
> > > > devices don't have their fwnode set. This used to be ignored
> > > > silently.
> > > >
> > > > Set the fwnode mipi_dsi_device so fw_devlink can find them and
> > > > properly
> > > > track their dependencies.
> > > >
> > > > This fixes errors like this:
> > > > [ 0.334054] nwl-dsi 30a00000.mipi-dsi: Failed to create device
> > > > link with regulator-lcd-1v8
> > > > [ 0.346964] nwl-dsi 30a00000.mipi-dsi: Failed to create device
> > > > link with backlight-dsi
> > > >
> > > > Reported-by: Martin Kepplinger <[email protected]>
> > >
> > > Reported-and-tested-by: Martin Kepplinger <[email protected]>
> >
> > Maintainers,
> >
> > Nudge nudge. Will this be picked up for 6.3-rcX?
>
> Greg,
>
> Can you pick this up please? It's a fix that hasn't been picked up for
> a few months.
>
> Here's the link to the actual patch for your convenience:
> https://lore.kernel.org/lkml/[email protected]/#t
Sorry, I'm not quite sure what happened. I've applied it to drm-misc-fixes
Maxime
On Thu, 09 Mar 2023 22:39:09 -0800, Saravana Kannan wrote:
> After commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
> detection more robust"), fw_devlink prints an error when consumer
> devices don't have their fwnode set. This used to be ignored silently.
>
> Set the fwnode mipi_dsi_device so fw_devlink can find them and properly
> track their dependencies.
>
> [...]
Applied to drm/drm-misc (drm-misc-fixes).
Thanks!
Maxime
On Thu, May 4, 2023 at 12:51 AM Maxime Ripard <[email protected]> wrote:
>
> Hi Saravana,
>
> On Wed, May 03, 2023 at 09:40:05PM -0700, Saravana Kannan wrote:
> > On Fri, Mar 17, 2023 at 3:36 PM Saravana Kannan <[email protected]> wrote:
> > >
> > > On Sun, Mar 12, 2023 at 7:45 AM Martin Kepplinger
> > > <[email protected]> wrote:
> > > >
> > > > Am Donnerstag, dem 09.03.2023 um 22:39 -0800 schrieb Saravana Kannan:
> > > > > After commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
> > > > > detection more robust"), fw_devlink prints an error when consumer
> > > > > devices don't have their fwnode set. This used to be ignored
> > > > > silently.
> > > > >
> > > > > Set the fwnode mipi_dsi_device so fw_devlink can find them and
> > > > > properly
> > > > > track their dependencies.
> > > > >
> > > > > This fixes errors like this:
> > > > > [ 0.334054] nwl-dsi 30a00000.mipi-dsi: Failed to create device
> > > > > link with regulator-lcd-1v8
> > > > > [ 0.346964] nwl-dsi 30a00000.mipi-dsi: Failed to create device
> > > > > link with backlight-dsi
> > > > >
> > > > > Reported-by: Martin Kepplinger <[email protected]>
> > > >
> > > > Reported-and-tested-by: Martin Kepplinger <[email protected]>
> > >
> > > Maintainers,
> > >
> > > Nudge nudge. Will this be picked up for 6.3-rcX?
> >
> > Greg,
> >
> > Can you pick this up please? It's a fix that hasn't been picked up for
> > a few months.
> >
> > Here's the link to the actual patch for your convenience:
> > https://lore.kernel.org/lkml/[email protected]/#t
>
> Sorry, I'm not quite sure what happened. I've applied it to drm-misc-fixes
No worries. Thanks Maxime!
-Saravana