2024-01-24 19:42:31

by Arseniy Krasnov

Subject: [PATCH net-next v1] vsock/test: print type for SOCK_SEQPACKET

SOCK_SEQPACKET is supported for virtio transport, so do not interpret
such type of socket as unknown.

Signed-off-by: Arseniy Krasnov <[email protected]>
---
tools/testing/vsock/vsock_diag_test.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/testing/vsock/vsock_diag_test.c b/tools/testing/vsock/vsock_diag_test.c
index 5e6049226b77..17aeba7cbd14 100644
--- a/tools/testing/vsock/vsock_diag_test.c
+++ b/tools/testing/vsock/vsock_diag_test.c
@@ -39,6 +39,8 @@ static const char *sock_type_str(int type)
return "DGRAM";
case SOCK_STREAM:
return "STREAM";
+ case SOCK_SEQPACKET:
+ return "SEQPACKET";
default:
return "INVALID TYPE";
}
--
2.25.1

2024-01-25 08:27:30

by Stefano Garzarella

Subject: Re: [PATCH net-next v1] vsock/test: print type for SOCK_SEQPACKET

On Wed, Jan 24, 2024 at 10:32:55PM +0300, Arseniy Krasnov wrote:
>SOCK_SEQPACKET is supported for virtio transport, so do not interpret
>such type of socket as unknown.
>
>Signed-off-by: Arseniy Krasnov <[email protected]>
>---
> tools/testing/vsock/vsock_diag_test.c | 2 ++
> 1 file changed, 2 insertions(+)

Yeah, LGTM!

Reviewed-by: Stefano Garzarella <[email protected]>

>
>diff --git a/tools/testing/vsock/vsock_diag_test.c b/tools/testing/vsock/vsock_diag_test.c
>index 5e6049226b77..17aeba7cbd14 100644
>--- a/tools/testing/vsock/vsock_diag_test.c
>+++ b/tools/testing/vsock/vsock_diag_test.c
>@@ -39,6 +39,8 @@ static const char *sock_type_str(int type)
> return "DGRAM";
> case SOCK_STREAM:
> return "STREAM";
>+ case SOCK_SEQPACKET:
>+ return "SEQPACKET";
> default:
> return "INVALID TYPE";
> }
>--
>2.25.1
>

2024-01-25 22:49:22

by Michael S. Tsirkin

Subject: Re: [PATCH net-next v1] vsock/test: print type for SOCK_SEQPACKET

On Wed, Jan 24, 2024 at 10:32:55PM +0300, Arseniy Krasnov wrote:
> SOCK_SEQPACKET is supported for virtio transport, so do not interpret
> such type of socket as unknown.
>
> Signed-off-by: Arseniy Krasnov <[email protected]>


Acked-by: Michael S. Tsirkin <[email protected]>

> ---
> tools/testing/vsock/vsock_diag_test.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/vsock/vsock_diag_test.c b/tools/testing/vsock/vsock_diag_test.c
> index 5e6049226b77..17aeba7cbd14 100644
> --- a/tools/testing/vsock/vsock_diag_test.c
> +++ b/tools/testing/vsock/vsock_diag_test.c
> @@ -39,6 +39,8 @@ static const char *sock_type_str(int type)
> return "DGRAM";
> case SOCK_STREAM:
> return "STREAM";
> + case SOCK_SEQPACKET:
> + return "SEQPACKET";
> default:
> return "INVALID TYPE";
> }
> --
> 2.25.1

2024-01-26 00:50:39

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next v1] vsock/test: print type for SOCK_SEQPACKET

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Wed, 24 Jan 2024 22:32:55 +0300 you wrote:
> SOCK_SEQPACKET is supported for virtio transport, so do not interpret
> such type of socket as unknown.
>
> Signed-off-by: Arseniy Krasnov <[email protected]>
> ---
> tools/testing/vsock/vsock_diag_test.c | 2 ++
> 1 file changed, 2 insertions(+)

Here is the summary with links:
- [net-next,v1] vsock/test: print type for SOCK_SEQPACKET
https://git.kernel.org/netdev/net-next/c/767ec326f985

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html