2020-05-09 01:12:37

by Zou Wei

Subject: [PATCH -next v2] livepatch: Make klp_apply_object_relocs static

Fix the following sparse warning:

kernel/livepatch/core.c:748:5: warning: symbol 'klp_apply_object_relocs' was not declared.

The klp_apply_object_relocs() has only one call site within core.c
It should be static

Fixes: 7c8e2bdd5f0d ("livepatch: Apply vmlinux-specific KLP relocations early")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Samuel Zou <[email protected]>
---
kernel/livepatch/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index 96d2da1..f76fdb9 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -745,7 +745,8 @@ static int klp_init_func(struct klp_object *obj, struct klp_func *func)
func->old_sympos ? func->old_sympos : 1);
}

-int klp_apply_object_relocs(struct klp_patch *patch, struct klp_object *obj)
+static int klp_apply_object_relocs(struct klp_patch *patch,
+ struct klp_object *obj)
{
int i, ret;
struct klp_modinfo *info = patch->mod->klp_info;
--
2.6.2

2020-05-10 23:24:14

by Jiri Kosina

Subject: Re: [PATCH -next v2] livepatch: Make klp_apply_object_relocs static

On Sat, 9 May 2020, Samuel Zou wrote:

> Fix the following sparse warning:
>
> kernel/livepatch/core.c:748:5: warning: symbol 'klp_apply_object_relocs' was not declared.
>
> The klp_apply_object_relocs() has only one call site within core.c
> It should be static
>
> Fixes: 7c8e2bdd5f0d ("livepatch: Apply vmlinux-specific KLP relocations early")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Samuel Zou <[email protected]>

Merged in for-5.8/klp-module-fixups branch now. Thanks,

--
Jiri Kosina
SUSE Labs