2022-11-03 16:24:00

by Benjamin Tissoires

Subject: [PATCH hid v12 01/15] HID: fix I2C_HID not selected when I2C_HID_OF_ELAN is

When I2C_HID_OF_ELAN is set, we need to turn on I2C_HID_CORE to
ensure we get all the HID requirements.

Fixes: bd3cba00dcc6 ("HID: i2c-hid: elan: Add support for Elan eKTH6915 i2c-hid touchscreens")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Benjamin Tissoires <[email protected]>

---

new in v12
---
drivers/hid/i2c-hid/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/i2c-hid/Kconfig b/drivers/hid/i2c-hid/Kconfig
index 5273ee2bb134..d65abe65ce73 100644
--- a/drivers/hid/i2c-hid/Kconfig
+++ b/drivers/hid/i2c-hid/Kconfig
@@ -66,6 +66,6 @@ endmenu

config I2C_HID_CORE
tristate
- default y if I2C_HID_ACPI=y || I2C_HID_OF=y || I2C_HID_OF_GOODIX=y
- default m if I2C_HID_ACPI=m || I2C_HID_OF=m || I2C_HID_OF_GOODIX=m
+ default y if I2C_HID_ACPI=y || I2C_HID_OF=y || I2C_HID_OF_ELAN=y || I2C_HID_OF_GOODIX=y
+ default m if I2C_HID_ACPI=m || I2C_HID_OF=m || I2C_HID_OF_ELAN=m || I2C_HID_OF_GOODIX=m
select HID
--
2.36.1

2022-11-15 16:45:37

by Jiri Kosina

Subject: Re: [PATCH hid v12 01/15] HID: fix I2C_HID not selected when I2C_HID_OF_ELAN is

On Thu, 3 Nov 2022, Benjamin Tissoires wrote:

> When I2C_HID_OF_ELAN is set, we need to turn on I2C_HID_CORE to
> ensure we get all the HID requirements.
>
> Fixes: bd3cba00dcc6 ("HID: i2c-hid: elan: Add support for Elan eKTH6915 i2c-hid touchscreens")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Benjamin Tissoires <[email protected]>
>
> ---
>
> new in v12

As this one has in principle nothing to do with the HID-BPF support, and
is actually a functional fix, I've cherry-picked this one into
hid.git#for-6.1/upstream-fixes.

Thanks,

--
Jiri Kosina
SUSE Labs