2023-05-29 22:45:09

by Rahul Rameshbabu

[permalink] [raw]
Subject: [PATCH RFC v1 0/3] HID: nvidia-shield: More functionality on top of initial driver

This patch series introduces more functionality on top of the initial
nvidia-shield HID driver sent to the linux-input mailing list. The android
media buttons, capacitive slider, and led on the Thunderstrike controller
are now supported. If possible, would appreciate an acknowledgment of the
initial driver patch or more feedback if needed.

Link: https://lore.kernel.org/linux-input/[email protected]/

Rahul Rameshbabu (3):
HID: nvidia-shield: Add mappings for consumer HID USAGE buttons
HID: nvidia-shield: Support LED functionality for Thunderstrike
HID: nvidia-shield: Remove space prefix from label in
shield_haptics_create

drivers/hid/hid-nvidia-shield.c | 173 ++++++++++++++++++++++++++++++--
1 file changed, 162 insertions(+), 11 deletions(-)

--
2.38.4



2023-05-29 22:46:53

by Rahul Rameshbabu

[permalink] [raw]
Subject: [PATCH RFC v1 3/3] HID: nvidia-shield: Remove space prefix from label in shield_haptics_create

Accidentally had a whitespace character in front of a label used for error
handling in the shield_haptics_create function.

Signed-off-by: Rahul Rameshbabu <[email protected]>
---

Notes:
This patch really should be updated in the initial patch that introduces
the nvidia-shield HID driver. Using a separate patch to just illustrate
this is a cosmetic change if needing to resubmit the original patch for
nvidia-shield.

Link: https://lore.kernel.org/linux-input/[email protected]/

drivers/hid/hid-nvidia-shield.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-nvidia-shield.c b/drivers/hid/hid-nvidia-shield.c
index 7dfaec1c07e2..85700cec5eac 100644
--- a/drivers/hid/hid-nvidia-shield.c
+++ b/drivers/hid/hid-nvidia-shield.c
@@ -202,7 +202,7 @@ static struct input_dev *shield_haptics_create(

return haptics;

- err:
+err:
input_free_device(haptics);
return ERR_PTR(ret);
}
--
2.38.4


2023-06-09 16:40:34

by Jiri Kosina

[permalink] [raw]
Subject: Re: [PATCH RFC v1 0/3] HID: nvidia-shield: More functionality on top of initial driver

On Mon, 29 May 2023, Rahul Rameshbabu wrote:

> This patch series introduces more functionality on top of the initial
> nvidia-shield HID driver sent to the linux-input mailing list. The android
> media buttons, capacitive slider, and led on the Thunderstrike controller
> are now supported. If possible, would appreciate an acknowledgment of the
> initial driver patch or more feedback if needed.
>
> Link: https://lore.kernel.org/linux-input/[email protected]/
>
> Rahul Rameshbabu (3):
> HID: nvidia-shield: Add mappings for consumer HID USAGE buttons
> HID: nvidia-shield: Support LED functionality for Thunderstrike
> HID: nvidia-shield: Remove space prefix from label in
> shield_haptics_create

Applied first 1/3 and 2/3 on top of for-6.5/nvidia; the third one was not
needed, as that branch is based on v4 already.

Thanks,

--
Jiri Kosina
SUSE Labs