2023-06-20 09:12:28

by Bastien Nocera

Subject: [PATCH] HID: logitech-hidpp: Rename HID++ "internal" error constant

As per the upstream "hidpp" helpers commit:
"
There has been some confusion about error value 5 but feature specs that
refer to it generally use NOT_ALLOWED.
"

Signed-off-by: Bastien Nocera <[email protected]>
Link: https://github.com/mrubli2/hidpp/commit/80c3fecfcd89c5efe0f16feabe90a55ddfd25aaa
---
drivers/hid/hid-logitech-hidpp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index 5e1a412fd28f..2dd86c23412b 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -228,7 +228,7 @@ struct hidpp_device {
#define HIDPP20_ERROR_INVALID_ARGS 0x02
#define HIDPP20_ERROR_OUT_OF_RANGE 0x03
#define HIDPP20_ERROR_HW_ERROR 0x04
-#define HIDPP20_ERROR_LOGITECH_INTERNAL 0x05
+#define HIDPP20_ERROR_NOT_ALLOWED 0x05
#define HIDPP20_ERROR_INVALID_FEATURE_INDEX 0x06
#define HIDPP20_ERROR_INVALID_FUNCTION_ID 0x07
#define HIDPP20_ERROR_BUSY 0x08
--
2.40.1

2023-08-14 09:52:29

by Jiri Kosina

Subject: Re: [PATCH] HID: logitech-hidpp: Rename HID++ "internal" error constant

On Tue, 20 Jun 2023, Bastien Nocera wrote:

> As per the upstream "hidpp" helpers commit:
> "
> There has been some confusion about error value 5 but feature specs that
> refer to it generally use NOT_ALLOWED.
> "

Applied, thanks.

--
Jiri Kosina
SUSE Labs