2024-05-07 06:37:40

by Kenny Levinsen

Subject: [PATCH] HID: i2c-hid: Remove unused label in i2c_hid_set_power

This label was left behind when the wake-up logic was moved from
i2c_hid_set_power to i2c_hid_probe_address. Clean it up as it causes
warnings-as-errors builds to fail.

Fixes: bb1033c8a3ea ("HID: i2c-hid: Use address probe to wake on resume")
Signed-off-by: Kenny Levinsen <[email protected]>
---
drivers/hid/i2c-hid/i2c-hid-core.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
index 3e3885ae6ce2..632eaf9e11a6 100644
--- a/drivers/hid/i2c-hid/i2c-hid-core.c
+++ b/drivers/hid/i2c-hid/i2c-hid-core.c
@@ -407,8 +407,6 @@ static int i2c_hid_set_power(struct i2c_hid *ihid, int power_state)
dev_err(&ihid->client->dev,
"failed to change power setting.\n");

-set_pwr_exit:
-
/*
* The HID over I2C specification states that if a DEVICE needs time
* after the PWR_ON request, it should utilise CLOCK stretching.
--
2.45.0

2024-05-07 08:43:19

by Jiri Kosina

Subject: Re: [PATCH] HID: i2c-hid: Remove unused label in i2c_hid_set_power

On Tue, 7 May 2024, Kenny Levinsen wrote:

> This label was left behind when the wake-up logic was moved from
> i2c_hid_set_power to i2c_hid_probe_address. Clean it up as it causes
> warnings-as-errors builds to fail.
>
> Fixes: bb1033c8a3ea ("HID: i2c-hid: Use address probe to wake on resume")
> Signed-off-by: Kenny Levinsen <[email protected]>

I have added

Reported-by: Stephen Rothwell <[email protected]>

and applied, thanks.

--
Jiri Kosina
SUSE Labs