2024-05-25 15:18:41

by Jeff Johnson

Subject: [PATCH 0/2] HID: intel-ish-hid: fix some 'make W=1' warnings

Clean up some 'make W=1' warnings

---
Jeff Johnson (2):
HID: intel-ish-hid: fix ishtp_wait_resume() kernel-doc
HID: intel-ish-hid: add MODULE_DESCRIPTION()

drivers/hid/intel-ish-hid/ishtp/bus.c | 2 ++
1 file changed, 2 insertions(+)
---
base-commit: 07506d1011521a4a0deec1c69721c7405c40049b
change-id: 20240525-kd-ishtp_wait_resume-95f01596b772

2024-05-25 15:18:58

by Jeff Johnson

Subject: [PATCH 1/2] HID: intel-ish-hid: fix ishtp_wait_resume() kernel-doc

Fix the 'make W=1' kernel-doc warning:

drivers/hid/intel-ish-hid/ishtp/bus.c:853: warning: Function parameter or struct member 'dev' not described in 'ishtp_wait_resume'

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Jeff Johnson <[email protected]>
---
drivers/hid/intel-ish-hid/ishtp/bus.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c b/drivers/hid/intel-ish-hid/ishtp/bus.c
index 03d5601ce807..f3042c4b8710 100644
--- a/drivers/hid/intel-ish-hid/ishtp/bus.c
+++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
@@ -844,6 +844,7 @@ EXPORT_SYMBOL(ishtp_device);

/**
* ishtp_wait_resume() - Wait for IPC resume
+ * @dev: ishtp device
*
* Wait for IPC resume
*

--
2.42.0

2024-06-03 08:43:14

by srinivas pandruvada

Subject: Re: [PATCH 1/2] HID: intel-ish-hid: fix ishtp_wait_resume() kernel-doc

On Sat, 2024-05-25 at 08:17 -0700, Jeff Johnson wrote:
> Fix the 'make W=1' kernel-doc warning:
>
> drivers/hid/intel-ish-hid/ishtp/bus.c:853: warning: Function
> parameter or struct member 'dev' not described in 'ishtp_wait_resume'
>
> Reported-by: kernel test robot <[email protected]>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Jeff Johnson <[email protected]>
Acked-by: Srinivas Pandruvada <[email protected]>

> ---
>  drivers/hid/intel-ish-hid/ishtp/bus.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c
> b/drivers/hid/intel-ish-hid/ishtp/bus.c
> index 03d5601ce807..f3042c4b8710 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/bus.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
> @@ -844,6 +844,7 @@ EXPORT_SYMBOL(ishtp_device);
>  
>  /**
>   * ishtp_wait_resume() - Wait for IPC resume
> + * @dev: ishtp device
>   *
>   * Wait for IPC resume
>   *
>

2024-06-04 08:20:11

by Jiri Kosina

Subject: Re: [PATCH 0/2] HID: intel-ish-hid: fix some 'make W=1' warnings

On Sat, 25 May 2024, Jeff Johnson wrote:

> Clean up some 'make W=1' warnings
>
> ---
> Jeff Johnson (2):
> HID: intel-ish-hid: fix ishtp_wait_resume() kernel-doc
> HID: intel-ish-hid: add MODULE_DESCRIPTION()
>
> drivers/hid/intel-ish-hid/ishtp/bus.c | 2 ++
> 1 file changed, 2 insertions(+)
> ---

Applied, thank you.

--
Jiri Kosina
SUSE Labs