2023-09-05 16:24:03

by Jacopo Mondi

[permalink] [raw]
Subject: Re: [PATCH] media: i2c: max9286: Remove an incorrect fwnode_handle_put() call

Hi Christophe,

On Wed, Aug 30, 2023 at 10:57:36PM +0200, Christophe JAILLET wrote:
> The commit in Fixes has removed an fwnode_handle_put() call in the error
> handling path of max9286_v4l2_register().
>
> Remove the same call from max9286_v4l2_unregister().
>
> Fixes: 1029939b3782 ("media: v4l: async: Simplify async sub-device fwnode matching")
> Signed-off-by: Christophe JAILLET <[email protected]>

Reviewed-by: Jacopo Mondi <[email protected]>

Thanks
j

> ---
> drivers/media/i2c/max9286.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> index f27a69b1b727..fc1cf196ef01 100644
> --- a/drivers/media/i2c/max9286.c
> +++ b/drivers/media/i2c/max9286.c
> @@ -1110,7 +1110,6 @@ static int max9286_v4l2_register(struct max9286_priv *priv)
>
> static void max9286_v4l2_unregister(struct max9286_priv *priv)
> {
> - fwnode_handle_put(priv->sd.fwnode);
> v4l2_ctrl_handler_free(&priv->ctrls);
> v4l2_async_unregister_subdev(&priv->sd);
> max9286_v4l2_notifier_unregister(priv);
> --
> 2.34.1
>