2012-05-10 15:33:50

by Minchan Kim

Subject: [PATCH] cma: fix migration mode

__alloc_contig_migrate_range calls migrate_pages with wrong argument
for migrate_mode. Fix it.

Cc: Marek Szyprowski <[email protected]>
Signed-off-by: Minchan Kim <[email protected]>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 4d926f1..9febc62 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5689,7 +5689,7 @@ static int __alloc_contig_migrate_range(unsigned long start, unsigned long end)

ret = migrate_pages(&cc.migratepages,
__alloc_contig_migrate_alloc,
- 0, false, true);
+ 0, false, MIGRATE_SYNC);
}

putback_lru_pages(&cc.migratepages);
--
1.7.9.5

2012-05-11 02:19:32

by Michal Nazarewicz

Subject: Re: [PATCH] cma: fix migration mode

On Thu, 10 May 2012 08:33:23 -0700, Minchan Kim <[email protected]> wrote:
> __alloc_contig_migrate_range calls migrate_pages with wrong argument
> for migrate_mode. Fix it.
>
> Cc: Marek Szyprowski <[email protected]>
> Signed-off-by: Minchan Kim <[email protected]>

Acked-by: Michal Nazarewicz <[email protected]>

> ---
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 4d926f1..9febc62 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5689,7 +5689,7 @@ static int __alloc_contig_migrate_range(unsigned long start, unsigned long end)
> ret = migrate_pages(&cc.migratepages,
> __alloc_contig_migrate_alloc,
> - 0, false, true);
> + 0, false, MIGRATE_SYNC);
> }
> putback_lru_pages(&cc.migratepages);


--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: [email protected]>--------------ooO--(_)--Ooo--

2012-05-11 08:13:30

by Marek Szyprowski

Subject: RE: [PATCH] cma: fix migration mode

Hello,

On Friday, May 11, 2012 4:19 AM Michal Nazarewicz wrote:

> On Thu, 10 May 2012 08:33:23 -0700, Minchan Kim <[email protected]> wrote:
> > __alloc_contig_migrate_range calls migrate_pages with wrong argument
> > for migrate_mode. Fix it.
> >
> > Cc: Marek Szyprowski <[email protected]>
> > Signed-off-by: Minchan Kim <[email protected]>
>
> Acked-by: Michal Nazarewicz <[email protected]>
>
> > ---
> > mm/page_alloc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> > index 4d926f1..9febc62 100644
> > --- a/mm/page_alloc.c
> > +++ b/mm/page_alloc.c
> > @@ -5689,7 +5689,7 @@ static int __alloc_contig_migrate_range(unsigned long start, unsigned
> long end)
> > ret = migrate_pages(&cc.migratepages,
> > __alloc_contig_migrate_alloc,
> > - 0, false, true);
> > + 0, false, MIGRATE_SYNC);
> > }
> > putback_lru_pages(&cc.migratepages);
>

Thanks for the patch, I will add it to my kernel tree.

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center