I've rebased the series on the current HEAD and moved the def_hostnqn bits from
the second patch to the third. This should make it more consistent in commit
history.
Also retested and found a bug in the context matching code in libnvme which I
post a fix too.
changes:
v3:
- rebased
- moved def_hostnqn bits from second patch to third
v2:
- https://lore.kernel.org/linux-nvme/[email protected]/
- nvme/048:
- untaggle waiting for state change and queue count check
- make all variables local
- compare numbers not strings
- nvme/rc:
- rename _nvme_cli_supports_context to _have_nvme_cli_context
- only add --context for fc
- reordered setup/cleanup
- nvme/{041,042,043,044,045,048}:
- move all changes related to this patch
v1:
- https://lore.kernel.org/linux-nvme/[email protected]/
Daniel Wagner (3):
nvme/048: Check for queue count check directly
nvme/rc: Avoid triggering host nvme-cli autoconnect
nvme/{041,042,043,044,045,048}: Use default hostnqn and hostid
tests/nvme/041 | 8 ++---
tests/nvme/042 | 8 ++---
tests/nvme/043 | 8 ++---
tests/nvme/044 | 8 ++---
tests/nvme/045 | 8 ++---
tests/nvme/048 | 32 +++++++++++++-------
tests/nvme/rc | 81 +++++++++++++++++++++++++++++++++++++++-----------
7 files changed, 96 insertions(+), 57 deletions(-)
--
2.41.0
On Jul 03, 2023 / 11:16, Daniel Wagner wrote:
> I've rebased the series on the current HEAD and moved the def_hostnqn bits from
> the second patch to the third. This should make it more consistent in commit
> history.
>
> Also retested and found a bug in the context matching code in libnvme which I
> post a fix too.
Thanks Daniel.
One thing I noticed is that now the 3rd patch removes the references from
nvme/rc to /etc/nvme/hostid and /etc/nvme/hostnqn. I'm ok with this change since
I see the motivation discussed here [1]. I will wait for several days to make
sure it's ok for others. In case anyone relies on those files to set up blktests
environment, please speak up.
[1] https://lore.kernel.org/linux-nvme/ajcm6yupguickaucansiuzjqatyz5qijnnp4topxv64cisbblc@4sgv3bd3jl4q/
Other that, changes in v3 looks good to me. If there is no voice, I'll apply
the patches as they are.
On 7/4/2023 12:08 AM, Shinichiro Kawasaki wrote:
> On Jul 03, 2023 / 11:16, Daniel Wagner wrote:
>> I've rebased the series on the current HEAD and moved the def_hostnqn bits from
>> the second patch to the third. This should make it more consistent in commit
>> history.
>>
>> Also retested and found a bug in the context matching code in libnvme which I
>> post a fix too.
>
> Thanks Daniel.
>
> One thing I noticed is that now the 3rd patch removes the references from
> nvme/rc to /etc/nvme/hostid and /etc/nvme/hostnqn. I'm ok with this change since
> I see the motivation discussed here [1]. I will wait for several days to make
> sure it's ok for others. In case anyone relies on those files to set up blktests
> environment, please speak up.
>
> [1] https://lore.kernel.org/linux-nvme/ajcm6yupguickaucansiuzjqatyz5qijnnp4topxv64cisbblc@4sgv3bd3jl4q/
>
> Other that, changes in v3 looks good to me. If there is no voice, I'll apply
> the patches as they are.
Adding Max and Yi who were part of original discussion [1].
-ck