2017-09-22 22:12:11

by Akemi Yagi

Subject: Build failure of kernel v4.14-rc due to error in tools/perf

Hi,

The build of kernel v4.14-rc1 for i686 fails on RHEL 6 with the error
in tools/perf:

util/syscalltbl.c:157: error: expected ';', ',' or ')' before '__maybe_unused'
mv: cannot stat `util/.syscalltbl.o.tmp': No such file or directory

This is fixed by placing/moving

#include <linux/compiler.h>

outside of #ifdef HAVE_SYSCALL_TABLE as shown in the patch below.

Thanks,

Akemi Yagi <[email protected]>
2017-09-22

--- a/tools/perf/util/syscalltbl.c 2017-09-16 15:47:51.000000000 -0700
+++ b/tools/perf/util/syscalltbl.c 2017-09-22 00:16:16.119007615 -0700
@@ -15,9 +15,9 @@

#include "syscalltbl.h"
#include <stdlib.h>
+#include <linux/compiler.h>

#ifdef HAVE_SYSCALL_TABLE
-#include <linux/compiler.h>
#include <string.h>
#include "string2.h"
#include "util.h"

2017-09-29 20:07:57

by tip-bot for Vasyl Gomonovych

Subject: [tip:perf/urgent] perf tools: Fix syscalltbl build failure

Commit-ID: 090657c9fb7094e4c1b05c1713d6c2a12ef43dea
Gitweb: https://git.kernel.org/tip/090657c9fb7094e4c1b05c1713d6c2a12ef43dea
Author: Akemi Yagi <[email protected]>
AuthorDate: Fri, 22 Sep 2017 22:11:53 +0000
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 25 Sep 2017 12:21:05 -0300

perf tools: Fix syscalltbl build failure

The build of kernel v4.14-rc1 for i686 fails on RHEL 6 with the error
in tools/perf:

util/syscalltbl.c:157: error: expected ';', ',' or ')' before '__maybe_unused'
mv: cannot stat `util/.syscalltbl.o.tmp': No such file or directory

Fix it by placing/moving:

#include <linux/compiler.h>

outside of #ifdef HAVE_SYSCALL_TABLE block.

Signed-off-by: Akemi Yagi <[email protected]>
Cc: Alan Bartlett <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/util/syscalltbl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/syscalltbl.c b/tools/perf/util/syscalltbl.c
index 19e5db9..6eea7cf 100644
--- a/tools/perf/util/syscalltbl.c
+++ b/tools/perf/util/syscalltbl.c
@@ -15,9 +15,9 @@

#include "syscalltbl.h"
#include <stdlib.h>
+#include <linux/compiler.h>

#ifdef HAVE_SYSCALL_TABLE
-#include <linux/compiler.h>
#include <string.h>
#include "string2.h"
#include "util.h"