2023-07-01 06:55:32

by Arseniy Krasnov

Subject: [RFC PATCH v5 12/17] vsock/loopback: support MSG_ZEROCOPY for transport

Add 'msgzerocopy_allow()' callback for loopback transport.

Signed-off-by: Arseniy Krasnov <[email protected]>
---
Changelog:
v4 -> v5:
* Move 'msgzerocopy_allow' right after seqpacket callbacks.
* Don't use prototype for 'vsock_loopback_msgzerocopy_allow()'.

net/vmw_vsock/vsock_loopback.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/net/vmw_vsock/vsock_loopback.c b/net/vmw_vsock/vsock_loopback.c
index 5c6360df1f31..048640167411 100644
--- a/net/vmw_vsock/vsock_loopback.c
+++ b/net/vmw_vsock/vsock_loopback.c
@@ -47,6 +47,10 @@ static int vsock_loopback_cancel_pkt(struct vsock_sock *vsk)
}

static bool vsock_loopback_seqpacket_allow(u32 remote_cid);
+static bool vsock_loopback_msgzerocopy_allow(void)
+{
+ return true;
+}

static struct virtio_transport loopback_transport = {
.transport = {
@@ -79,6 +83,8 @@ static struct virtio_transport loopback_transport = {
.seqpacket_allow = vsock_loopback_seqpacket_allow,
.seqpacket_has_data = virtio_transport_seqpacket_has_data,

+ .msgzerocopy_allow = vsock_loopback_msgzerocopy_allow,
+
.notify_poll_in = virtio_transport_notify_poll_in,
.notify_poll_out = virtio_transport_notify_poll_out,
.notify_recv_init = virtio_transport_notify_recv_init,
--
2.25.1

2023-07-06 17:35:54

by Stefano Garzarella

Subject: Re: [RFC PATCH v5 12/17] vsock/loopback: support MSG_ZEROCOPY for transport

On Sat, Jul 01, 2023 at 09:39:42AM +0300, Arseniy Krasnov wrote:
>Add 'msgzerocopy_allow()' callback for loopback transport.
>
>Signed-off-by: Arseniy Krasnov <[email protected]>
>---
> Changelog:
> v4 -> v5:
> * Move 'msgzerocopy_allow' right after seqpacket callbacks.
> * Don't use prototype for 'vsock_loopback_msgzerocopy_allow()'.
>
> net/vmw_vsock/vsock_loopback.c | 6 ++++++
> 1 file changed, 6 insertions(+)

Reviewed-by: Stefano Garzarella <[email protected]>

>
>diff --git a/net/vmw_vsock/vsock_loopback.c b/net/vmw_vsock/vsock_loopback.c
>index 5c6360df1f31..048640167411 100644
>--- a/net/vmw_vsock/vsock_loopback.c
>+++ b/net/vmw_vsock/vsock_loopback.c
>@@ -47,6 +47,10 @@ static int vsock_loopback_cancel_pkt(struct vsock_sock *vsk)
> }
>
> static bool vsock_loopback_seqpacket_allow(u32 remote_cid);
>+static bool vsock_loopback_msgzerocopy_allow(void)
>+{
>+ return true;
>+}
>
> static struct virtio_transport loopback_transport = {
> .transport = {
>@@ -79,6 +83,8 @@ static struct virtio_transport loopback_transport = {
> .seqpacket_allow = vsock_loopback_seqpacket_allow,
> .seqpacket_has_data = virtio_transport_seqpacket_has_data,
>
>+ .msgzerocopy_allow = vsock_loopback_msgzerocopy_allow,
>+
> .notify_poll_in = virtio_transport_notify_poll_in,
> .notify_poll_out = virtio_transport_notify_poll_out,
> .notify_recv_init = virtio_transport_notify_recv_init,
>--
>2.25.1
>