2010-04-07 04:04:36

by Jan III Sobieski

Subject: [PATCH] build error drivers/staging/dt3155/dt3155_drv.c

Hi,

CC drivers/staging/dt3155/dt3155_drv.o
drivers/staging/dt3155/dt3155_drv.c: In function 'init_module':
drivers/staging/dt3155/dt3155_drv.c:1047: error: implicit declaration
of function 'request_irq'
drivers/staging/dt3155/dt3155_drv.c:1048: error: 'IRQF_SHARED'
undeclared (first use in this function)
drivers/staging/dt3155/dt3155_drv.c:1048: error: (Each undeclared
identifier is reported only once
drivers/staging/dt3155/dt3155_drv.c:1048: error: for each function it
appears in.)
drivers/staging/dt3155/dt3155_drv.c:1048: error: 'IRQF_DISABLED'
undeclared (first use in this function)
drivers/staging/dt3155/dt3155_drv.c: In function 'cleanup_module':
drivers/staging/dt3155/dt3155_drv.c:1091: error: implicit declaration
of function 'free_irq'
make[3]: *** [drivers/staging/dt3155/dt3155_drv.o] B??d 1
make[2]: *** [drivers/staging/dt3155] B??d 2
make[1]: *** [drivers/staging] B??d 2
make: *** [drivers] B??d 2


--
Jan III Sobieski

Signed-off-by: Jan III Sobieski <[email protected]>

--- linux-2.6-git/drivers/staging/dt3155/dt3155_drv.c 2010-03-27
22:34:58.000000000 +0100
+++ linux-2.6/drivers/staging/dt3155/dt3155_drv.c 2010-04-07
05:54:07.000000000 +0200
@@ -74,6 +74,7 @@ MODULE_LICENSE("GPL");
#include <linux/types.h>
#include <linux/poll.h>
#include <linux/sched.h>
+#include <linux/interrupt.h>

#include <asm/io.h>
#include <asm/uaccess.h>

2010-04-07 04:05:26

by Jan III Sobieski

Subject: Re: [PATCH] build error drivers/staging/dt3155/dt3155_drv.c

W dniu 7 kwietnia 2010 06:04 u?ytkownik Jan III Sobieski
<[email protected]> napisa?:
> Hi,
>
> ?CC ? ? ?drivers/staging/dt3155/dt3155_drv.o
> drivers/staging/dt3155/dt3155_drv.c: In function 'init_module':
> drivers/staging/dt3155/dt3155_drv.c:1047: error: implicit declaration
> of function 'request_irq'
> drivers/staging/dt3155/dt3155_drv.c:1048: error: 'IRQF_SHARED'
> undeclared (first use in this function)
> drivers/staging/dt3155/dt3155_drv.c:1048: error: (Each undeclared
> identifier is reported only once
> drivers/staging/dt3155/dt3155_drv.c:1048: error: for each function it
> appears in.)
> drivers/staging/dt3155/dt3155_drv.c:1048: error: 'IRQF_DISABLED'
> undeclared (first use in this function)
> drivers/staging/dt3155/dt3155_drv.c: In function 'cleanup_module':
> drivers/staging/dt3155/dt3155_drv.c:1091: error: implicit declaration
> of function 'free_irq'
> make[3]: *** [drivers/staging/dt3155/dt3155_drv.o] B??d 1
> make[2]: *** [drivers/staging/dt3155] B??d 2
> make[1]: *** [drivers/staging] B??d 2
> make: *** [drivers] B??d 2

BTW. Kernel 2.6.34-rc3-git6

>
>
> --
> Jan III Sobieski
>
> Signed-off-by: Jan III Sobieski <[email protected]>
>
> --- linux-2.6-git/drivers/staging/dt3155/dt3155_drv.c ? 2010-03-27
> 22:34:58.000000000 +0100
> +++ linux-2.6/drivers/staging/dt3155/dt3155_drv.c ? ? ? 2010-04-07
> 05:54:07.000000000 +0200
> @@ -74,6 +74,7 @@ MODULE_LICENSE("GPL");
> ?#include <linux/types.h>
> ?#include <linux/poll.h>
> ?#include <linux/sched.h>
> +#include <linux/interrupt.h>
>
> ?#include <asm/io.h>
> ?#include <asm/uaccess.h>
>



--
Jan III Sobieski

2010-04-13 22:20:34

by Jan III Sobieski

Subject: Re: [PATCH] build error drivers/staging/dt3155/dt3155_drv.c

W dniu 7 kwietnia 2010 06:05 u?ytkownik Jan III Sobieski
<[email protected]> napisa?:
> W dniu 7 kwietnia 2010 06:04 u?ytkownik Jan III Sobieski
> <[email protected]> napisa?:
>> Hi,
>>
>> ?CC ? ? ?drivers/staging/dt3155/dt3155_drv.o
>> drivers/staging/dt3155/dt3155_drv.c: In function 'init_module':
>> drivers/staging/dt3155/dt3155_drv.c:1047: error: implicit declaration
>> of function 'request_irq'
>> drivers/staging/dt3155/dt3155_drv.c:1048: error: 'IRQF_SHARED'
>> undeclared (first use in this function)
>> drivers/staging/dt3155/dt3155_drv.c:1048: error: (Each undeclared
>> identifier is reported only once
>> drivers/staging/dt3155/dt3155_drv.c:1048: error: for each function it
>> appears in.)
>> drivers/staging/dt3155/dt3155_drv.c:1048: error: 'IRQF_DISABLED'
>> undeclared (first use in this function)
>> drivers/staging/dt3155/dt3155_drv.c: In function 'cleanup_module':
>> drivers/staging/dt3155/dt3155_drv.c:1091: error: implicit declaration
>> of function 'free_irq'
>> make[3]: *** [drivers/staging/dt3155/dt3155_drv.o] B??d 1
>> make[2]: *** [drivers/staging/dt3155] B??d 2
>> make[1]: *** [drivers/staging] B??d 2
>> make: *** [drivers] B??d 2
>
> BTW. Kernel 2.6.34-rc3-git6

I still get this bug on 2.6.34-rc4. Anyone care to pick this patch?

--
Jan III Sobieski

2010-04-13 22:25:50

by Randy Dunlap

Subject: Re: [PATCH] build error drivers/staging/dt3155/dt3155_drv.c

On Wed, 14 Apr 2010 00:20:31 +0200 Jan III Sobieski wrote:

> W dniu 7 kwietnia 2010 06:05 użytkownik Jan III Sobieski
> <[email protected]> napisał:
> > W dniu 7 kwietnia 2010 06:04 użytkownik Jan III Sobieski
> > <[email protected]> napisał:
> >> Hi,
> >>
> >>  CC      drivers/staging/dt3155/dt3155_drv.o
> >> drivers/staging/dt3155/dt3155_drv.c: In function 'init_module':
> >> drivers/staging/dt3155/dt3155_drv.c:1047: error: implicit declaration
> >> of function 'request_irq'
> >> drivers/staging/dt3155/dt3155_drv.c:1048: error: 'IRQF_SHARED'
> >> undeclared (first use in this function)
> >> drivers/staging/dt3155/dt3155_drv.c:1048: error: (Each undeclared
> >> identifier is reported only once
> >> drivers/staging/dt3155/dt3155_drv.c:1048: error: for each function it
> >> appears in.)
> >> drivers/staging/dt3155/dt3155_drv.c:1048: error: 'IRQF_DISABLED'
> >> undeclared (first use in this function)
> >> drivers/staging/dt3155/dt3155_drv.c: In function 'cleanup_module':
> >> drivers/staging/dt3155/dt3155_drv.c:1091: error: implicit declaration
> >> of function 'free_irq'
> >> make[3]: *** [drivers/staging/dt3155/dt3155_drv.o] Błąd 1
> >> make[2]: *** [drivers/staging/dt3155] Błąd 2
> >> make[1]: *** [drivers/staging] Błąd 2
> >> make: *** [drivers] Błąd 2
> >
> > BTW. Kernel 2.6.34-rc3-git6
>
> I still get this bug on 2.6.34-rc4. Anyone care to pick this patch?


I sent a patch on March 09, 2010, that should fix it.
Please test it. Thanks.

---
From: Randy Dunlap <[email protected]>

When the dt3155 driver is built-in (not as a loadable module),
these build errors happen:

drivers/staging/dt3155/dt3155_drv.c:1047: error: implicit declaration of function 'request_irq'
drivers/staging/dt3155/dt3155_drv.c:1048: error: 'IRQF_SHARED' undeclared (first use in this function)
drivers/staging/dt3155/dt3155_drv.c:1048: error: 'IRQF_DISABLED' undeclared (first use in this function)
drivers/staging/dt3155/dt3155_drv.c:1091: error: implicit declaration of function 'free_irq'

so remove the #ifdef MODULE check since it's not needed.
Also remove the CONFIG_PCI check since the Kconfig file already
requires that.

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Scott Smedley <[email protected]>
---
drivers/staging/dt3155/dt3155_drv.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)

--- linux-next-20100309.orig/drivers/staging/dt3155/dt3155_drv.c
+++ linux-next-20100309/drivers/staging/dt3155/dt3155_drv.c
@@ -57,19 +57,8 @@ MA 02111-1307 USA

extern void printques(int);

-#ifdef MODULE
#include <linux/module.h>
#include <linux/interrupt.h>
-
-
-MODULE_LICENSE("GPL");
-
-#endif
-
-#ifndef CONFIG_PCI
-#error "DT3155 : Kernel PCI support not enabled (DT3155 drive requires PCI)"
-#endif
-
#include <linux/pci.h>
#include <linux/types.h>
#include <linux/poll.h>
@@ -84,6 +73,9 @@ MODULE_LICENSE("GPL");
#include "dt3155_io.h"
#include "allocator.h"

+
+MODULE_LICENSE("GPL");
+
/* Error variable. Zero means no error. */
int dt3155_errno = 0;