2006-08-30 16:02:20

by Mathieu Desnoyers

Subject: arch/x86_64/kernel/traps.c:show_trace should use __kernel_text_address

Hi,

I noticed arch/x86_64/kernel/traps.c:show_trace uses kernel_text_address to
verify that an address can potentially belong to kernel code. However, this
version takes a spinlock and should not be called from oops. I think
__kernel_text_address would be more appropriate there.

Mathieu Desnoyers


OpenPGP public key: http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68

2006-08-30 16:58:08

by Andi Kleen

Subject: Re: arch/x86_64/kernel/traps.c:show_trace should use __kernel_text_address

Mathieu Desnoyers <[email protected]> writes:

> Hi,
>
> I noticed arch/x86_64/kernel/traps.c:show_trace uses kernel_text_address to
> verify that an address can potentially belong to kernel code. However, this
> version takes a spinlock and should not be called from oops. I think
> __kernel_text_address would be more appropriate there.

Ok I changed it. Thanks

-Andi