Hi Andrew,
This is a resend of the first part of the patchset sent 2 weeks
ago. This is the part about the IPC which (again) proposes to consolidate
some part of the existing code.
It does not change the behavior of the existing code, but
improves it in term of readability and maintainability as it consolidates it
a little. As there was no objection, I think you can include them in your
-mm tree.
The patchset applies on top of "2.6.24-mm1 + previous patches about
IPC" sent the last days (ie Nadia's patches + mine).
For information, here is the global diffstat:
ipc/msg.c | 184 +++++++++++++++++++++++--------------------------------------
ipc/sem.c | 156 ++++++++++++++++++---------------------------------
ipc/shm.c | 176 ++++++++++++++++++----------------------------------------
ipc/util.c | 64 +++++++++++++++++++++
ipc/util.h | 3
5 files changed, 249 insertions(+), 334 deletions(-)
and the size of the resulting kernel:
- without the patchset:
$ size obj/vmlinux.ori
text data bss dec hex filename
1903257 175820 122880 2201957 219965 obj/vmlinux.ori
- with the patchset:
$ size obj/vmlinux
text data bss dec hex filename
1902917 175820 122880 2201617 219811 obj/vmlinux
--
Pierre Peiffer
[email protected] writes:
> This is a resend of the first part of the patchset sent 2 weeks
> ago. This is the part about the IPC which (again) proposes to consolidate
> some part of the existing code.
>
> It does not change the behavior of the existing code, but
> improves it in term of readability and maintainability as it consolidates it
> a little. As there was no objection, I think you can include them in your
> -mm tree.
>
> The patchset applies on top of "2.6.24-mm1 + previous patches about
> IPC" sent the last days (ie Nadia's patches + mine).
While I have not read everything in detail from a quick overview
the whole patch series looks like a nice and valuable cleanup to me.
I was a bit sceptical about all the interface enhancements your original
patchkit had, but this one looks just fine.
-Andi
Andi Kleen wrote:
> [email protected] writes:
>
>> This is a resend of the first part of the patchset sent 2 weeks
>> ago. This is the part about the IPC which (again) proposes to consolidate
>> some part of the existing code.
>>
>> It does not change the behavior of the existing code, but
>> improves it in term of readability and maintainability as it consolidates it
>> a little. As there was no objection, I think you can include them in your
>> -mm tree.
>>
>> The patchset applies on top of "2.6.24-mm1 + previous patches about
>> IPC" sent the last days (ie Nadia's patches + mine).
>
> While I have not read everything in detail from a quick overview
> the whole patch series looks like a nice and valuable cleanup to me.
>
> I was a bit sceptical about all the interface enhancements your original
> patchkit had, but this one looks just fine.
>
Thanks Andi for spending time on this review.
All kind of comments (positive or negative) are always welcome to make progress,
but of course, I particularly appreciate such positive feedbacks ;)
--
Pierre