2003-01-02 06:22:36

by Andres Salomon

[permalink] [raw]
Subject: [PATCH] 2.5.54 atyfb_base.c compile fix

atyfb doesn't compile for me; this fixes it. Someone was referencing the
wrong variable (or fb_cursor and aty_cursor used to be similar, and
fb_cursor changed).


--- a/drivers/video/aty/atyfb_base.c.orig 2003-01-02 00:22:48.000000000 -0500
+++ b/drivers/video/aty/atyfb_base.c 2003-01-02 01:24:15.000000000 -0500
@@ -2605,12 +2605,12 @@
if (info->screen_base)
iounmap((void *) info->screen_base);
#ifdef __BIG_ENDIAN
- if (info->cursor && info->cursor->ram)
- iounmap(info->cursor->ram);
+ if (par->cursor && par->cursor->ram)
+ iounmap(par->cursor->ram);
#endif
#endif
- if (info->cursor)
- kfree(info->cursor);
+ if (par->cursor)
+ kfree(par->cursor);
#ifdef __sparc__
if (par->mmap_map)
kfree(par->mmap_map);




2003-01-06 22:01:19

by Andres Salomon

[permalink] [raw]
Subject: Re: [PATCH] 2.5.54 atyfb_base.c compile fix

Cool. Now if only atyfb didn't completely mess up my console in 2.4 and
2.5, on my Dell Inspiron 3800 (Rage Mobility P/M, AGP 2x)..

I have too many other projects I'm working on right now to dedicate a
lot of time trying to fix it, but if you had suggestions for what to
try, I'd appreciate it.

Simply loading the atyfb module, without any args, causes the screen to
go blank. I can see the cursor blinking, but I can't see any text
output.

On Mon, Jan 06, 2003 at 09:50:04PM +0000, James Simmons wrote:
> From: James Simmons <[email protected]>
> To: Andres Salomon <[email protected]>
> Cc: [email protected]
> Subject: Re: [PATCH] 2.5.54 atyfb_base.c compile fix
>
>
> Applied.

--
It's not denial. I'm just selective about the reality I accept.
-- Bill Watterson

2003-01-07 21:51:05

by James Simmons

[permalink] [raw]
Subject: Re: [PATCH] 2.5.54 atyfb_base.c compile fix


> I have too many other projects I'm working on right now to dedicate a
> lot of time trying to fix it, but if you had suggestions for what to
> try, I'd appreciate it.
>
> Simply loading the atyfb module, without any args, causes the screen to
> go blank. I can see the cursor blinking, but I can't see any text
> output.

These means atyfb changes the video mode when you insmod. Since the card
usually has a VGA core we shouldn't set the video mode when insmoding.
This way we can insmod the driver and still have VGA text mode. Then
insmoding font.ko and fbcon.ko would load framebuffer console.