2023-06-22 09:07:50

by Neil Armstrong

Subject: [PATCH 5/5] arm64: dts: qcom: sdm845-mtp: add chassis-type property

Qualcomm's Mobile Test Platforms devices are handsets, set the
chassis-type property to 'handset'.

Signed-off-by: Neil Armstrong <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
index b2d4336e764b..41675a8de268 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
@@ -15,6 +15,7 @@
/ {
model = "Qualcomm Technologies, Inc. SDM845 MTP";
compatible = "qcom,sdm845-mtp", "qcom,sdm845";
+ chassis-type = "handset";

aliases {
serial0 = &uart9;

--
2.34.1

2023-06-22 09:32:13

by Konrad Dybcio

Subject: Re: [PATCH 5/5] arm64: dts: qcom: sdm845-mtp: add chassis-type property

On 22.06.2023 10:57, Neil Armstrong wrote:
> Qualcomm's Mobile Test Platforms devices are handsets, set the
> chassis-type property to 'handset'.
>
> Signed-off-by: Neil Armstrong <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> index b2d4336e764b..41675a8de268 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> @@ -15,6 +15,7 @@
> / {
> model = "Qualcomm Technologies, Inc. SDM845 MTP";
> compatible = "qcom,sdm845-mtp", "qcom,sdm845";
> + chassis-type = "handset";
>
> aliases {
> serial0 = &uart9;
>

2023-06-22 11:00:04

by Dmitry Baryshkov

Subject: Re: [PATCH 5/5] arm64: dts: qcom: sdm845-mtp: add chassis-type property

On Thu, 22 Jun 2023 at 12:06, Neil Armstrong <[email protected]> wrote:
>
> Qualcomm's Mobile Test Platforms devices are handsets, set the
> chassis-type property to 'handset'.

Is it really a device that you can take into your hand and put close
to the head?

>
> Signed-off-by: Neil Armstrong <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> index b2d4336e764b..41675a8de268 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> @@ -15,6 +15,7 @@
> / {
> model = "Qualcomm Technologies, Inc. SDM845 MTP";
> compatible = "qcom,sdm845-mtp", "qcom,sdm845";
> + chassis-type = "handset";
>
> aliases {
> serial0 = &uart9;
>
> --
> 2.34.1
>


--
With best wishes
Dmitry

2023-06-22 11:24:35

by Konrad Dybcio

Subject: Re: [PATCH 5/5] arm64: dts: qcom: sdm845-mtp: add chassis-type property

On 22.06.2023 12:48, Dmitry Baryshkov wrote:
> On Thu, 22 Jun 2023 at 12:06, Neil Armstrong <[email protected]> wrote:
>>
>> Qualcomm's Mobile Test Platforms devices are handsets, set the
>> chassis-type property to 'handset'.
>
> Is it really a device that you can take into your hand and put close
> to the head?
If you don't mind getting a bit microwavey, yes

Konrad
>
>>
>> Signed-off-by: Neil Armstrong <[email protected]>
>> ---
>> arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
>> index b2d4336e764b..41675a8de268 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
>> @@ -15,6 +15,7 @@
>> / {
>> model = "Qualcomm Technologies, Inc. SDM845 MTP";
>> compatible = "qcom,sdm845-mtp", "qcom,sdm845";
>> + chassis-type = "handset";
>>
>> aliases {
>> serial0 = &uart9;
>>
>> --
>> 2.34.1
>>
>
>

2023-06-22 11:46:20

by Krzysztof Kozlowski

Subject: Re: [PATCH 5/5] arm64: dts: qcom: sdm845-mtp: add chassis-type property

On 22/06/2023 12:49, Konrad Dybcio wrote:
> On 22.06.2023 12:48, Dmitry Baryshkov wrote:
>> On Thu, 22 Jun 2023 at 12:06, Neil Armstrong <[email protected]> wrote:
>>>
>>> Qualcomm's Mobile Test Platforms devices are handsets, set the
>>> chassis-type property to 'handset'.
>>
>> Is it really a device that you can take into your hand and put close
>> to the head?
> If you don't mind getting a bit microwavey, yes

Handset should not poke your brain, so the chassis is not really
handset. Maybe it is just embedded?

Best regards,
Krzysztof

2023-07-10 05:04:45

by Bjorn Andersson

Subject: Re: [PATCH 5/5] arm64: dts: qcom: sdm845-mtp: add chassis-type property

On Thu, Jun 22, 2023 at 01:48:30PM +0300, Dmitry Baryshkov wrote:
> On Thu, 22 Jun 2023 at 12:06, Neil Armstrong <[email protected]> wrote:
> >
> > Qualcomm's Mobile Test Platforms devices are handsets, set the
> > chassis-type property to 'handset'.
>
> Is it really a device that you can take into your hand and put close
> to the head?
>

It's a little bit bulky, but it looks like a handset.

Regards,
Bjorn

> >
> > Signed-off-by: Neil Armstrong <[email protected]>
> > ---
> > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> > index b2d4336e764b..41675a8de268 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> > @@ -15,6 +15,7 @@
> > / {
> > model = "Qualcomm Technologies, Inc. SDM845 MTP";
> > compatible = "qcom,sdm845-mtp", "qcom,sdm845";
> > + chassis-type = "handset";
> >
> > aliases {
> > serial0 = &uart9;
> >
> > --
> > 2.34.1
> >
>
>
> --
> With best wishes
> Dmitry