Hi Greg, few stable updates for you -
Cheers,
Kent
The following changes since commit 0dd3ee31125508cd67f7e7172247f05b7fd1753a:
Linux 6.7 (2024-01-07 12:18:38 -0800)
are available in the Git repository at:
https://evilpiepirate.org/git/bcachefs.git tags/bcachefs-for-v6.7-stable-20240208
for you to fetch changes up to f1582f4774ac7c30c5460a8c7a6e5a82b9ce5a6a:
bcachefs: time_stats: Check for last_event == 0 when updating freq stats (2024-02-08 15:33:11 -0500)
----------------------------------------------------------------
bcachefs updates for v6.7 stable:
locking fixes in subvolume create, destroy paths - Al, Su Yue, Guoyu Ou
fix race in thread_with_file - Mathias Krause
small rebalance fixes - Daniel, myself
workaround for building with old clang (can't take a pointer to memcmp)
build fix on parisc
minor time_stats fix
----------------------------------------------------------------
Al Viro (2):
new helper: user_path_locked_at()
bch2_ioctl_subvolume_destroy(): fix locking
Christoph Hellwig (1):
bcachefs: fix incorrect usage of REQ_OP_FLUSH
Daniel Hill (1):
bcachefs: rebalance should wakeup on shutdown if disabled
Guoyu Ou (1):
bcachefs: unlock parent dir if entry is not found in subvolume deletion
Helge Deller (1):
bcachefs: Fix build on parisc by avoiding __multi3()
Kent Overstreet (4):
bcachefs: Don't pass memcmp() as a pointer
bcachefs: Add missing bch2_moving_ctxt_flush_all()
bcachefs: bch2_kthread_io_clock_wait() no longer sleeps until full amount
bcachefs: time_stats: Check for last_event == 0 when updating freq stats
Mathias Krause (1):
bcachefs: install fd later to avoid race with close
Su Yue (2):
bcachefs: kvfree bch_fs::snapshots in bch2_fs_snapshots_exit
bcachefs: grab s_umount only if snapshotting
fs/bcachefs/chardev.c | 3 +--
fs/bcachefs/clock.c | 4 ++--
fs/bcachefs/fs-io.c | 2 +-
fs/bcachefs/fs-ioctl.c | 42 +++++++++++++++++++++--------------------
fs/bcachefs/journal_io.c | 3 ++-
fs/bcachefs/mean_and_variance.h | 2 +-
fs/bcachefs/move.c | 2 +-
fs/bcachefs/move.h | 1 +
fs/bcachefs/rebalance.c | 13 +++++++++++--
fs/bcachefs/replicas.c | 10 ++++++++--
fs/bcachefs/snapshot.c | 2 +-
fs/bcachefs/util.c | 5 +++--
fs/namei.c | 16 +++++++++++++---
include/linux/namei.h | 1 +
14 files changed, 68 insertions(+), 38 deletions(-)
On Thu, Feb 08, 2024 at 08:14:39PM -0500, Kent Overstreet wrote:
> Hi Greg, few stable updates for you -
>
> Cheers,
> Kent
>
> The following changes since commit 0dd3ee31125508cd67f7e7172247f05b7fd1753a:
>
> Linux 6.7 (2024-01-07 12:18:38 -0800)
>
> are available in the Git repository at:
>
> https://evilpiepirate.org/git/bcachefs.git tags/bcachefs-for-v6.7-stable-20240208
>
> for you to fetch changes up to f1582f4774ac7c30c5460a8c7a6e5a82b9ce5a6a:
>
> bcachefs: time_stats: Check for last_event == 0 when updating freq stats (2024-02-08 15:33:11 -0500)
This didn't work well :(
All of the original git commit ids are gone, and for me to look them up
and add them back by hand is a pain. I'll do it this time, but next
time can you please include them in the commit somewhere (cherry-pick -x
will do it automatically for you)
Let's see if I can figure it out...
thanks,
greg k-h
On Tue, Feb 13, 2024 at 03:38:10PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Feb 08, 2024 at 08:14:39PM -0500, Kent Overstreet wrote:
> > Hi Greg, few stable updates for you -
> >
> > Cheers,
> > Kent
> >
> > The following changes since commit 0dd3ee31125508cd67f7e7172247f05b7fd1753a:
> >
> > Linux 6.7 (2024-01-07 12:18:38 -0800)
> >
> > are available in the Git repository at:
> >
> > https://evilpiepirate.org/git/bcachefs.git tags/bcachefs-for-v6.7-stable-20240208
> >
> > for you to fetch changes up to f1582f4774ac7c30c5460a8c7a6e5a82b9ce5a6a:
> >
> > bcachefs: time_stats: Check for last_event == 0 when updating freq stats (2024-02-08 15:33:11 -0500)
>
> This didn't work well :(
>
> All of the original git commit ids are gone, and for me to look them up
> and add them back by hand is a pain. I'll do it this time, but next
> time can you please include them in the commit somewhere (cherry-pick -x
> will do it automatically for you)
>
> Let's see if I can figure it out...
I got all but 3 applied, can you please send an updated set of 3 patches
for the ones I couldn't just cherry-pick from Linus's tree?
thanks,
greg k-h
On Tue, Feb 13, 2024 at 03:38:10PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Feb 08, 2024 at 08:14:39PM -0500, Kent Overstreet wrote:
> > Hi Greg, few stable updates for you -
> >
> > Cheers,
> > Kent
> >
> > The following changes since commit 0dd3ee31125508cd67f7e7172247f05b7fd1753a:
> >
> > Linux 6.7 (2024-01-07 12:18:38 -0800)
> >
> > are available in the Git repository at:
> >
> > https://evilpiepirate.org/git/bcachefs.git tags/bcachefs-for-v6.7-stable-20240208
> >
> > for you to fetch changes up to f1582f4774ac7c30c5460a8c7a6e5a82b9ce5a6a:
> >
> > bcachefs: time_stats: Check for last_event == 0 when updating freq stats (2024-02-08 15:33:11 -0500)
>
> This didn't work well :(
>
> All of the original git commit ids are gone, and for me to look them up
> and add them back by hand is a pain. I'll do it this time, but next
> time can you please include them in the commit somewhere (cherry-pick -x
> will do it automatically for you)
Ah, apologies - I was pretty sure I was supposed to do something like
cherry-pick -x; couldn't find the option and then went looking through
the stable log, and I didn't see the tag anywhere?
New pull request inc momentarily...
On Tue, Feb 13, 2024 at 03:44:25PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Feb 13, 2024 at 03:38:10PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Feb 08, 2024 at 08:14:39PM -0500, Kent Overstreet wrote:
> > > Hi Greg, few stable updates for you -
> > >
> > > Cheers,
> > > Kent
> > >
> > > The following changes since commit 0dd3ee31125508cd67f7e7172247f05b7fd1753a:
> > >
> > > Linux 6.7 (2024-01-07 12:18:38 -0800)
> > >
> > > are available in the Git repository at:
> > >
> > > https://evilpiepirate.org/git/bcachefs.git tags/bcachefs-for-v6.7-stable-20240208
> > >
> > > for you to fetch changes up to f1582f4774ac7c30c5460a8c7a6e5a82b9ce5a6a:
> > >
> > > bcachefs: time_stats: Check for last_event == 0 when updating freq stats (2024-02-08 15:33:11 -0500)
> >
> > This didn't work well :(
> >
> > All of the original git commit ids are gone, and for me to look them up
> > and add them back by hand is a pain. I'll do it this time, but next
> > time can you please include them in the commit somewhere (cherry-pick -x
> > will do it automatically for you)
> >
> > Let's see if I can figure it out...
>
> I got all but 3 applied, can you please send an updated set of 3 patches
> for the ones I couldn't just cherry-pick from Linus's tree?
New pull request work?
The following changes since commit 0dd3ee31125508cd67f7e7172247f05b7fd1753a:
Linux 6.7 (2024-01-07 12:18:38 -0800)
are available in the Git repository at:
https://evilpiepirate.org/git/bcachefs.git tags/bcachefs-6.7-stable-2024-02-13
for you to fetch changes up to b291ceeb4faa9ee34d1704116fe393d66ff1f221:
bcachefs: time_stats: Check for last_event == 0 when updating freq stats (2024-02-13 21:22:41 -0500)
----------------------------------------------------------------
bcachefs fixes for 6.7 stable
----------------------------------------------------------------
Al Viro (2):
new helper: user_path_locked_at()
bch2_ioctl_subvolume_destroy(): fix locking
Christoph Hellwig (1):
bcachefs: fix incorrect usage of REQ_OP_FLUSH
Daniel Hill (1):
bcachefs: rebalance should wakeup on shutdown if disabled
Guoyu Ou (1):
bcachefs: unlock parent dir if entry is not found in subvolume deletion
Helge Deller (1):
bcachefs: Fix build on parisc by avoiding __multi3()
Kent Overstreet (4):
bcachefs: Don't pass memcmp() as a pointer
bcachefs: Add missing bch2_moving_ctxt_flush_all()
bcachefs: bch2_kthread_io_clock_wait() no longer sleeps until full amount
bcachefs: time_stats: Check for last_event == 0 when updating freq stats
Mathias Krause (1):
bcachefs: install fd later to avoid race with close
Su Yue (2):
bcachefs: kvfree bch_fs::snapshots in bch2_fs_snapshots_exit
bcachefs: grab s_umount only if snapshotting
fs/bcachefs/chardev.c | 3 +--
fs/bcachefs/clock.c | 4 ++--
fs/bcachefs/fs-io.c | 2 +-
fs/bcachefs/fs-ioctl.c | 42 +++++++++++++++++++++--------------------
fs/bcachefs/journal_io.c | 3 ++-
fs/bcachefs/mean_and_variance.h | 2 +-
fs/bcachefs/move.c | 2 +-
fs/bcachefs/move.h | 1 +
fs/bcachefs/rebalance.c | 13 +++++++++++--
fs/bcachefs/replicas.c | 10 ++++++++--
fs/bcachefs/snapshot.c | 2 +-
fs/bcachefs/util.c | 5 +++--
fs/namei.c | 16 +++++++++++++---
include/linux/namei.h | 1 +
14 files changed, 68 insertions(+), 38 deletions(-)
On Tue, Feb 13, 2024 at 09:28:37PM -0500, Kent Overstreet wrote:
> On Tue, Feb 13, 2024 at 03:44:25PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Feb 13, 2024 at 03:38:10PM +0100, Greg Kroah-Hartman wrote:
> > > On Thu, Feb 08, 2024 at 08:14:39PM -0500, Kent Overstreet wrote:
> > > > Hi Greg, few stable updates for you -
> > > >
> > > > Cheers,
> > > > Kent
> > > >
> > > > The following changes since commit 0dd3ee31125508cd67f7e7172247f05b7fd1753a:
> > > >
> > > > Linux 6.7 (2024-01-07 12:18:38 -0800)
> > > >
> > > > are available in the Git repository at:
> > > >
> > > > https://evilpiepirate.org/git/bcachefs.git tags/bcachefs-for-v6.7-stable-20240208
> > > >
> > > > for you to fetch changes up to f1582f4774ac7c30c5460a8c7a6e5a82b9ce5a6a:
> > > >
> > > > bcachefs: time_stats: Check for last_event == 0 when updating freq stats (2024-02-08 15:33:11 -0500)
> > >
> > > This didn't work well :(
> > >
> > > All of the original git commit ids are gone, and for me to look them up
> > > and add them back by hand is a pain. I'll do it this time, but next
> > > time can you please include them in the commit somewhere (cherry-pick -x
> > > will do it automatically for you)
> > >
> > > Let's see if I can figure it out...
> >
> > I got all but 3 applied, can you please send an updated set of 3 patches
> > for the ones I couldn't just cherry-pick from Linus's tree?
>
> New pull request work?
>
> The following changes since commit 0dd3ee31125508cd67f7e7172247f05b7fd1753a:
>
> Linux 6.7 (2024-01-07 12:18:38 -0800)
>
> are available in the Git repository at:
>
> https://evilpiepirate.org/git/bcachefs.git tags/bcachefs-6.7-stable-2024-02-13
Thanks, I'll look at these after this round of -rc kernels are released,
which should have most of these in the release alraedy, but not all.
greg k-h
On Wed, Feb 14, 2024 at 07:51:01AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Feb 13, 2024 at 09:28:37PM -0500, Kent Overstreet wrote:
> > On Tue, Feb 13, 2024 at 03:44:25PM +0100, Greg Kroah-Hartman wrote:
> > > On Tue, Feb 13, 2024 at 03:38:10PM +0100, Greg Kroah-Hartman wrote:
> > > > On Thu, Feb 08, 2024 at 08:14:39PM -0500, Kent Overstreet wrote:
> > > > > Hi Greg, few stable updates for you -
> > > > >
> > > > > Cheers,
> > > > > Kent
> > > > >
> > > > > The following changes since commit 0dd3ee31125508cd67f7e7172247f05b7fd1753a:
> > > > >
> > > > > Linux 6.7 (2024-01-07 12:18:38 -0800)
> > > > >
> > > > > are available in the Git repository at:
> > > > >
> > > > > https://evilpiepirate.org/git/bcachefs.git tags/bcachefs-for-v6.7-stable-20240208
> > > > >
> > > > > for you to fetch changes up to f1582f4774ac7c30c5460a8c7a6e5a82b9ce5a6a:
> > > > >
> > > > > bcachefs: time_stats: Check for last_event == 0 when updating freq stats (2024-02-08 15:33:11 -0500)
> > > >
> > > > This didn't work well :(
> > > >
> > > > All of the original git commit ids are gone, and for me to look them up
> > > > and add them back by hand is a pain. I'll do it this time, but next
> > > > time can you please include them in the commit somewhere (cherry-pick -x
> > > > will do it automatically for you)
> > > >
> > > > Let's see if I can figure it out...
> > >
> > > I got all but 3 applied, can you please send an updated set of 3 patches
> > > for the ones I couldn't just cherry-pick from Linus's tree?
> >
> > New pull request work?
> >
> > The following changes since commit 0dd3ee31125508cd67f7e7172247f05b7fd1753a:
> >
> > Linux 6.7 (2024-01-07 12:18:38 -0800)
> >
> > are available in the Git repository at:
> >
> > https://evilpiepirate.org/git/bcachefs.git tags/bcachefs-6.7-stable-2024-02-13
>
> Thanks, I'll look at these after this round of -rc kernels are released,
> which should have most of these in the release alraedy, but not all.
Didn't work, can you rebase on 6.7.5 please? I tried to rebase the tree
here, but it gave me rejects that I didn't know how to resolve.
thanks,
greg k-h
On Tue, Feb 20, 2024 at 03:34:52PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Feb 14, 2024 at 07:51:01AM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Feb 13, 2024 at 09:28:37PM -0500, Kent Overstreet wrote:
> > > On Tue, Feb 13, 2024 at 03:44:25PM +0100, Greg Kroah-Hartman wrote:
> > > > On Tue, Feb 13, 2024 at 03:38:10PM +0100, Greg Kroah-Hartman wrote:
> > > > > On Thu, Feb 08, 2024 at 08:14:39PM -0500, Kent Overstreet wrote:
> > > > > > Hi Greg, few stable updates for you -
> > > > > >
> > > > > > Cheers,
> > > > > > Kent
> > > > > >
> > > > > > The following changes since commit 0dd3ee31125508cd67f7e7172247f05b7fd1753a:
> > > > > >
> > > > > > Linux 6.7 (2024-01-07 12:18:38 -0800)
> > > > > >
> > > > > > are available in the Git repository at:
> > > > > >
> > > > > > https://evilpiepirate.org/git/bcachefs.git tags/bcachefs-for-v6.7-stable-20240208
> > > > > >
> > > > > > for you to fetch changes up to f1582f4774ac7c30c5460a8c7a6e5a82b9ce5a6a:
> > > > > >
> > > > > > bcachefs: time_stats: Check for last_event == 0 when updating freq stats (2024-02-08 15:33:11 -0500)
> > > > >
> > > > > This didn't work well :(
> > > > >
> > > > > All of the original git commit ids are gone, and for me to look them up
> > > > > and add them back by hand is a pain. I'll do it this time, but next
> > > > > time can you please include them in the commit somewhere (cherry-pick -x
> > > > > will do it automatically for you)
> > > > >
> > > > > Let's see if I can figure it out...
> > > >
> > > > I got all but 3 applied, can you please send an updated set of 3 patches
> > > > for the ones I couldn't just cherry-pick from Linus's tree?
> > >
> > > New pull request work?
> > >
> > > The following changes since commit 0dd3ee31125508cd67f7e7172247f05b7fd1753a:
> > >
> > > Linux 6.7 (2024-01-07 12:18:38 -0800)
> > >
> > > are available in the Git repository at:
> > >
> > > https://evilpiepirate.org/git/bcachefs.git tags/bcachefs-6.7-stable-2024-02-13
> >
> > Thanks, I'll look at these after this round of -rc kernels are released,
> > which should have most of these in the release alraedy, but not all.
>
> Didn't work, can you rebase on 6.7.5 please? I tried to rebase the tree
> here, but it gave me rejects that I didn't know how to resolve.
Because sasha cherry picked some of those fixes himself, despite an
explicit ack that he wouldn't.
And one of the fixes had a locking bug, and he missed the fix for that.
You're going to have to revert all that if you want my pull request to
apply.
On Tue, Feb 20, 2024 at 12:25:25PM -0500, Kent Overstreet wrote:
> On Tue, Feb 20, 2024 at 03:34:52PM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Feb 14, 2024 at 07:51:01AM +0100, Greg Kroah-Hartman wrote:
> > > On Tue, Feb 13, 2024 at 09:28:37PM -0500, Kent Overstreet wrote:
> > > > On Tue, Feb 13, 2024 at 03:44:25PM +0100, Greg Kroah-Hartman wrote:
> > > > > On Tue, Feb 13, 2024 at 03:38:10PM +0100, Greg Kroah-Hartman wrote:
> > > > > > On Thu, Feb 08, 2024 at 08:14:39PM -0500, Kent Overstreet wrote:
> > > > > > > Hi Greg, few stable updates for you -
> > > > > > >
> > > > > > > Cheers,
> > > > > > > Kent
> > > > > > >
> > > > > > > The following changes since commit 0dd3ee31125508cd67f7e7172247f05b7fd1753a:
> > > > > > >
> > > > > > > Linux 6.7 (2024-01-07 12:18:38 -0800)
> > > > > > >
> > > > > > > are available in the Git repository at:
> > > > > > >
> > > > > > > https://evilpiepirate.org/git/bcachefs.git tags/bcachefs-for-v6.7-stable-20240208
> > > > > > >
> > > > > > > for you to fetch changes up to f1582f4774ac7c30c5460a8c7a6e5a82b9ce5a6a:
> > > > > > >
> > > > > > > bcachefs: time_stats: Check for last_event == 0 when updating freq stats (2024-02-08 15:33:11 -0500)
> > > > > >
> > > > > > This didn't work well :(
> > > > > >
> > > > > > All of the original git commit ids are gone, and for me to look them up
> > > > > > and add them back by hand is a pain. I'll do it this time, but next
> > > > > > time can you please include them in the commit somewhere (cherry-pick -x
> > > > > > will do it automatically for you)
> > > > > >
> > > > > > Let's see if I can figure it out...
> > > > >
> > > > > I got all but 3 applied, can you please send an updated set of 3 patches
> > > > > for the ones I couldn't just cherry-pick from Linus's tree?
> > > >
> > > > New pull request work?
> > > >
> > > > The following changes since commit 0dd3ee31125508cd67f7e7172247f05b7fd1753a:
> > > >
> > > > Linux 6.7 (2024-01-07 12:18:38 -0800)
> > > >
> > > > are available in the Git repository at:
> > > >
> > > > https://evilpiepirate.org/git/bcachefs.git tags/bcachefs-6.7-stable-2024-02-13
> > >
> > > Thanks, I'll look at these after this round of -rc kernels are released,
> > > which should have most of these in the release alraedy, but not all.
> >
> > Didn't work, can you rebase on 6.7.5 please? I tried to rebase the tree
> > here, but it gave me rejects that I didn't know how to resolve.
>
> Because sasha cherry picked some of those fixes himself, despite an
> explicit ack that he wouldn't.
No, I rebased on a "clean" 6.7.5 that had no changes on top of it at
all. It had nothing to do with anything in the queue right now.
> And one of the fixes had a locking bug, and he missed the fix for that.
>
> You're going to have to revert all that if you want my pull request to
> apply.
I'll go drop those, sorry for them getting added, but again, this had
nothing to do with your pull request failing.
thanks,
greg k-h