2023-08-04 15:27:10

by Waqar Hameed

Subject: [PATCH 1/2] dt-bindings: rtc: Add Epson RX8111

Epson RX8111 is an RTC with timestamp functionality. Add devicetree
bindings requiring the compatible string and I2C slave address (reg).

Signed-off-by: Waqar Hameed <[email protected]>
---
.../devicetree/bindings/rtc/epson,rx8111.yaml | 41 +++++++++++++++++++
1 file changed, 41 insertions(+)
create mode 100644 Documentation/devicetree/bindings/rtc/epson,rx8111.yaml

diff --git a/Documentation/devicetree/bindings/rtc/epson,rx8111.yaml b/Documentation/devicetree/bindings/rtc/epson,rx8111.yaml
new file mode 100644
index 000000000000..e6f077a32582
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/epson,rx8111.yaml
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/epson,rx8111.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Epson RX8111 Real-Time Clock
+
+maintainers:
+ - Waqar Hameed <[email protected]>
+
+description: |
+ RTC with timestamp functionality.
+
+ https://support.epson.biz/td/api/doc_check.php?dl=app_RX8111CE&lang=en
+
+properties:
+ compatible:
+ const: epson,rx8111
+
+ reg:
+ const: 0x32
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ rtc@32 {
+ compatible = "epson,rx8111";
+ reg = <0x32>;
+ };
+ };
+...
--
2.30.2

2023-08-05 21:35:25

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/2] dt-bindings: rtc: Add Epson RX8111

On 04/08/2023 16:19, Waqar Hameed wrote:
> Epson RX8111 is an RTC with timestamp functionality. Add devicetree
> bindings requiring the compatible string and I2C slave address (reg).


> +
> +maintainers:
> + - Waqar Hameed <[email protected]>
> +
> +description: |
> + RTC with timestamp functionality.
> +
> + https://support.epson.biz/td/api/doc_check.php?dl=app_RX8111CE&lang=en
> +
> +properties:
> + compatible:
> + const: epson,rx8111
> +
> + reg:
> + const: 0x32
> +
> +required:
> + - compatible
> + - reg

Just add it to trivial-rtc.yaml. You miss here more things than trivial
is providing, so...

Best regards,
Krzysztof

2023-08-07 21:58:34

by Waqar Hameed

Subject: Re: [PATCH 1/2] dt-bindings: rtc: Add Epson RX8111

On Sat, Aug 05, 2023 at 22:28 +0200 Krzysztof Kozlowski <[email protected]> wrote:

> On 04/08/2023 16:19, Waqar Hameed wrote:
>> Epson RX8111 is an RTC with timestamp functionality. Add devicetree
>> bindings requiring the compatible string and I2C slave address (reg).
>
>
>> +
>> +maintainers:
>> + - Waqar Hameed <[email protected]>
>> +
>> +description: |
>> + RTC with timestamp functionality.
>> +
>> + https://support.epson.biz/td/api/doc_check.php?dl=app_RX8111CE&lang=en
>> +
>> +properties:
>> + compatible:
>> + const: epson,rx8111
>> +
>> + reg:
>> + const: 0x32
>> +
>> +required:
>> + - compatible
>> + - reg
>
> Just add it to trivial-rtc.yaml. You miss here more things than trivial
> is providing, so...

Oh, I wasn't even aware of that file. I'll add it there instead!