2023-09-19 19:04:52

by Axel Rasmussen

[permalink] [raw]
Subject: [PATCH 02/10] userfaultfd.2: reword to account for new fault resolution ioctls

Basically, reword the sentence to clarify that this isn't a complete
list. I don't believe it's worth maintaining a fully complete list here,
instead ioctl_userfaultfd.2 is the place to do that. Let this just be an
example.

Signed-off-by: Axel Rasmussen <[email protected]>
---
man2/userfaultfd.2 | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/man2/userfaultfd.2 b/man2/userfaultfd.2
index 1b2af22f9..00d94e514 100644
--- a/man2/userfaultfd.2
+++ b/man2/userfaultfd.2
@@ -222,11 +222,12 @@ operation,
a page fault occurring in the requested memory range, and satisfying
the mode defined at the registration time, will be forwarded by the kernel to
the user-space application.
-The application can then use the
+The application can then use various (e.g.
.B UFFDIO_COPY ,
.B UFFDIO_ZEROPAGE ,
or
.B UFFDIO_CONTINUE
+)
.BR ioctl (2)
operations to resolve the page fault.
.PP
--
2.42.0.459.ge4e396fd5e-goog


2023-09-25 23:31:02

by Alejandro Colomar

[permalink] [raw]
Subject: Re: [PATCH 02/10] userfaultfd.2: reword to account for new fault resolution ioctls

Hi Axel,

On Tue, Sep 19, 2023 at 12:01:58PM -0700, Axel Rasmussen wrote:
> Basically, reword the sentence to clarify that this isn't a complete
> list. I don't believe it's worth maintaining a fully complete list here,
> instead ioctl_userfaultfd.2 is the place to do that. Let this just be an
> example.
>
> Signed-off-by: Axel Rasmussen <[email protected]>

Patch applied.

Thanks,
Alex

> ---
> man2/userfaultfd.2 | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/man2/userfaultfd.2 b/man2/userfaultfd.2
> index 1b2af22f9..00d94e514 100644
> --- a/man2/userfaultfd.2
> +++ b/man2/userfaultfd.2
> @@ -222,11 +222,12 @@ operation,
> a page fault occurring in the requested memory range, and satisfying
> the mode defined at the registration time, will be forwarded by the kernel to
> the user-space application.
> -The application can then use the
> +The application can then use various (e.g.
> .B UFFDIO_COPY ,
> .B UFFDIO_ZEROPAGE ,
> or
> .B UFFDIO_CONTINUE
> +)
> .BR ioctl (2)
> operations to resolve the page fault.
> .PP
> --
> 2.42.0.459.ge4e396fd5e-goog
>

Attachments:
(No filename) (1.13 kB)
 signature.asc (849.00 B)
 Download all attachments

2023-10-09 08:41:14

by Mike Rapoport

[permalink] [raw]
Subject: Re: [PATCH 02/10] userfaultfd.2: reword to account for new fault resolution ioctls

On Tue, Sep 19, 2023 at 12:01:58PM -0700, Axel Rasmussen wrote:
> Basically, reword the sentence to clarify that this isn't a complete
> list. I don't believe it's worth maintaining a fully complete list here,
> instead ioctl_userfaultfd.2 is the place to do that. Let this just be an
> example.
>
> Signed-off-by: Axel Rasmussen <[email protected]>

Reviewed-by: Mike Rapoport (IBM) <[email protected]>

> ---
> man2/userfaultfd.2 | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/man2/userfaultfd.2 b/man2/userfaultfd.2
> index 1b2af22f9..00d94e514 100644
> --- a/man2/userfaultfd.2
> +++ b/man2/userfaultfd.2
> @@ -222,11 +222,12 @@ operation,
> a page fault occurring in the requested memory range, and satisfying
> the mode defined at the registration time, will be forwarded by the kernel to
> the user-space application.
> -The application can then use the
> +The application can then use various (e.g.
> .B UFFDIO_COPY ,
> .B UFFDIO_ZEROPAGE ,
> or
> .B UFFDIO_CONTINUE
> +)
> .BR ioctl (2)
> operations to resolve the page fault.
> .PP
> --
> 2.42.0.459.ge4e396fd5e-goog
>
>

--
Sincerely yours,
Mike.