2020-11-01 13:20:45

by Alexander Lobakin

Subject: [PATCH v2 net-next 1/2] net: add GSO UDP L4 and GSO fraglists to the list of software-backed types

Commit e20cf8d3f1f7 ("udp: implement GRO for plain UDP sockets.") and
commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") made UDP L4
and fraglisted GRO/GSO fully supported by the software fallback mode.
We can safely add them to NETIF_F_GSO_SOFTWARE to allow logical/virtual
netdevs to forward these types of skbs up to the real drivers.

Signed-off-by: Alexander Lobakin <[email protected]>
---
include/linux/netdev_features.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h
index 0b17c4322b09..934de56644e7 100644
--- a/include/linux/netdev_features.h
+++ b/include/linux/netdev_features.h
@@ -207,8 +207,8 @@ static inline int find_next_netdev_feature(u64 feature, unsigned long start)
NETIF_F_FSO)

/* List of features with software fallbacks. */
-#define NETIF_F_GSO_SOFTWARE (NETIF_F_ALL_TSO | \
- NETIF_F_GSO_SCTP)
+#define NETIF_F_GSO_SOFTWARE (NETIF_F_ALL_TSO | NETIF_F_GSO_SCTP | \
+ NETIF_F_GSO_UDP_L4 | NETIF_F_GSO_FRAGLIST)

/*
* If one device supports one of these features, then enable them
--
2.29.2

2020-11-02 15:15:35

by Willem de Bruijn

Subject: Re: [PATCH v2 net-next 1/2] net: add GSO UDP L4 and GSO fraglists to the list of software-backed types

On Sun, Nov 1, 2020 at 8:17 AM Alexander Lobakin <[email protected]> wrote:
>
> Commit e20cf8d3f1f7 ("udp: implement GRO for plain UDP sockets.") and
> commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") made UDP L4
> and fraglisted GRO/GSO fully supported by the software fallback mode.
> We can safely add them to NETIF_F_GSO_SOFTWARE to allow logical/virtual
> netdevs to forward these types of skbs up to the real drivers.
>
> Signed-off-by: Alexander Lobakin <[email protected]>

Acked-by: Willem de Bruijn <[email protected]>