2021-01-14 08:10:29

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH v6 15/16] drm: drm_crc: fix a kernel-doc markup

A function has a different name between their prototype
and its kernel-doc markup:

../include/drm/drm_crtc.h:1257: warning: expecting prototype for drm_crtc_alloc_with_planes(). Prototype was for drmm_crtc_alloc_with_planes() instead

Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---
include/drm/drm_crtc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index 540e2e43ec93..13eeba2a750a 100644
--- a/include/drm/drm_crtc.h
+++ b/include/drm/drm_crtc.h
@@ -1232,7 +1232,7 @@ void *__drmm_crtc_alloc_with_planes(struct drm_device *dev,
const char *name, ...);

/**
- * drm_crtc_alloc_with_planes - Allocate and initialize a new CRTC object with
+ * drmm_crtc_alloc_with_planes - Allocate and initialize a new CRTC object with
* specified primary and cursor planes.
* @dev: DRM device
* @type: the type of the struct which contains struct &drm_crtc
--
2.29.2


2021-01-14 08:10:54

by Simon Ser

[permalink] [raw]
Subject: Re: [PATCH v6 15/16] drm: drm_crc: fix a kernel-doc markup

On Thursday, January 14th, 2021 at 9:04 AM, Mauro Carvalho Chehab <[email protected]> wrote:

> A function has a different name between their prototype
> and its kernel-doc markup:
>
> ../include/drm/drm_crtc.h:1257: warning: expecting prototype for drm_crtc_alloc_with_planes(). Prototype was for drmm_crtc_alloc_with_planes() instead
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

Acked-by: Simon Ser <[email protected]>

2021-01-14 14:17:53

by Simon Ser

[permalink] [raw]
Subject: Re: [PATCH v6 15/16] drm: drm_crc: fix a kernel-doc markup

On Thursday, January 14th, 2021 at 9:06 AM, Simon Ser <[email protected]> wrote:

> On Thursday, January 14th, 2021 at 9:04 AM, Mauro Carvalho Chehab <[email protected]> wrote:
>
> > A function has a different name between their prototype
> > and its kernel-doc markup:
> >
> > ../include/drm/drm_crtc.h:1257: warning: expecting prototype for drm_crtc_alloc_with_planes(). Prototype was for drmm_crtc_alloc_with_planes() instead
> >
> > Signed-off-by: Mauro Carvalho Chehab <[email protected]>
>
> Acked-by: Simon Ser <[email protected]>

Pushed to drm-misc-next, thanks for the fix!