2024-03-30 20:27:56

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 1/2] drm/bridge: chipone-icn6211: drop driver owner assignment

Core in mipi_dsi_driver_register() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/bridge/chipone-icn6211.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
index 82d23e4df09e..43c1202701ee 100644
--- a/drivers/gpu/drm/bridge/chipone-icn6211.c
+++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
@@ -783,7 +783,6 @@ static struct mipi_dsi_driver chipone_dsi_driver = {
.remove = chipone_dsi_remove,
.driver = {
.name = "chipone-icn6211",
- .owner = THIS_MODULE,
.of_match_table = chipone_of_match,
},
};
--
2.34.1



2024-03-30 20:28:05

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 2/2] drm/bridge: tc358764: drop driver owner assignment

Core in mipi_dsi_driver_register() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/bridge/tc358764.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/tc358764.c b/drivers/gpu/drm/bridge/tc358764.c
index deccb3995022..3d3d135b4348 100644
--- a/drivers/gpu/drm/bridge/tc358764.c
+++ b/drivers/gpu/drm/bridge/tc358764.c
@@ -401,7 +401,6 @@ static struct mipi_dsi_driver tc358764_driver = {
.remove = tc358764_remove,
.driver = {
.name = "tc358764",
- .owner = THIS_MODULE,
.of_match_table = tc358764_of_match,
},
};
--
2.34.1


2024-04-24 06:42:00

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] drm/bridge: chipone-icn6211: drop driver owner assignment

On 30/03/2024 21:27, Krzysztof Kozlowski wrote:
> Core in mipi_dsi_driver_register() already sets the .owner, so driver
> does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---

It has been almost a month. Any comments on this patchset?

Best regards,
Krzysztof


2024-04-24 09:16:53

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 1/2] drm/bridge: chipone-icn6211: drop driver owner assignment

On Sat, Mar 30, 2024 at 09:27:40PM +0100, Krzysztof Kozlowski wrote:
> Core in mipi_dsi_driver_register() already sets the .owner, so driver
> does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/gpu/drm/bridge/chipone-icn6211.c | 1 -
> 1 file changed, 1 deletion(-)
>

Reviewed-by: Dmitry Baryshkov <[email protected]>


--
With best wishes
Dmitry

2024-04-24 09:17:39

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 2/2] drm/bridge: tc358764: drop driver owner assignment

On Sat, Mar 30, 2024 at 09:27:41PM +0100, Krzysztof Kozlowski wrote:
> Core in mipi_dsi_driver_register() already sets the .owner, so driver
> does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/gpu/drm/bridge/tc358764.c | 1 -
> 1 file changed, 1 deletion(-)
>

Reviewed-by: Dmitry Baryshkov <[email protected]>


--
With best wishes
Dmitry

2024-04-25 07:48:56

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH 1/2] drm/bridge: chipone-icn6211: drop driver owner assignment

Hi Dmitry,

On 24/04/2024 11:12, Dmitry Baryshkov wrote:
> On Sat, Mar 30, 2024 at 09:27:40PM +0100, Krzysztof Kozlowski wrote:
>> Core in mipi_dsi_driver_register() already sets the .owner, so driver
>> does not need to.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> ---
>> drivers/gpu/drm/bridge/chipone-icn6211.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>
> Reviewed-by: Dmitry Baryshkov <[email protected]>
>
>

I tried to apply them but you already applied them... could you make sure to notify the list when applying ?

Thanks,
Neil

2024-04-25 08:03:19

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH 1/2] drm/bridge: chipone-icn6211: drop driver owner assignment

On Thu, 25 Apr 2024 at 10:47, Neil Armstrong <[email protected]> wrote:
>
> Hi Dmitry,
>
> On 24/04/2024 11:12, Dmitry Baryshkov wrote:
> > On Sat, Mar 30, 2024 at 09:27:40PM +0100, Krzysztof Kozlowski wrote:
> >> Core in mipi_dsi_driver_register() already sets the .owner, so driver
> >> does not need to.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> >> ---
> >> drivers/gpu/drm/bridge/chipone-icn6211.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >
> > Reviewed-by: Dmitry Baryshkov <[email protected]>
> >
> >
>
> I tried to apply them but you already applied them... could you make sure to notify the list when applying ?

Ack, excuse me.



--
With best wishes
Dmitry