2008-08-02 22:45:07

by Grant Coady

Subject: [PATCH] GDT SCSI DISK ARRAY: fix split line comments for grep

Hi there,

Following patch unsplits some comment lines that hold driver device
names so they can be grepped.

Grant.

From: Grant Coady <[email protected]>

fix split line comments so grep can find scsi GDT* device IDs

Signed-off-by: Grant Coady <[email protected]>

---
gdth.h | 12 ++++--------
1 files changed, 4 insertions(+), 8 deletions(-)

--- linux-2.6.27-rc1-mm1/drivers/scsi/gdth.h~ 2008-07-14 07:51:29.000000000 +1000
+++ linux-2.6.27-rc1-mm1/drivers/scsi/gdth.h 2008-08-03 08:34:58.817704177 +1000
@@ -99,17 +99,13 @@
#define PCI_DEVICE_ID_VORTEX_GDT6x11RD 0x114 /* GDT6111RD/GDT6511RD */
#define PCI_DEVICE_ID_VORTEX_GDT6x21RD 0x115 /* GDT6121RD/GDT6521RD */
/* GDT_MPR, RD series, wide/ultra2 SCSI */
-#define PCI_DEVICE_ID_VORTEX_GDT6x18RD 0x118 /* GDT6118RD/GDT6518RD/
- GDT6618RD */
-#define PCI_DEVICE_ID_VORTEX_GDT6x28RD 0x119 /* GDT6128RD/GDT6528RD/
- GDT6628RD */
+#define PCI_DEVICE_ID_VORTEX_GDT6x18RD 0x118 /* GDT6118RD/GDT6518RD/GDT6618RD */
+#define PCI_DEVICE_ID_VORTEX_GDT6x28RD 0x119 /* GDT6128RD/GDT6528RD/GDT6628RD */
#define PCI_DEVICE_ID_VORTEX_GDT6x38RD 0x11A /* GDT6538RD/GDT6638RD */
#define PCI_DEVICE_ID_VORTEX_GDT6x58RD 0x11B /* GDT6558RD/GDT6658RD */
/* GDT_MPR, RN series (64-bit PCI), wide/ultra2 SCSI */
-#define PCI_DEVICE_ID_VORTEX_GDT7x18RN 0x168 /* GDT7118RN/GDT7518RN/
- GDT7618RN */
-#define PCI_DEVICE_ID_VORTEX_GDT7x28RN 0x169 /* GDT7128RN/GDT7528RN/
- GDT7628RN */
+#define PCI_DEVICE_ID_VORTEX_GDT7x18RN 0x168 /* GDT7118RN/GDT7518RN/GDT7618RN */
+#define PCI_DEVICE_ID_VORTEX_GDT7x28RN 0x169 /* GDT7128RN/GDT7528RN/GDT7628RN */
#define PCI_DEVICE_ID_VORTEX_GDT7x38RN 0x16A /* GDT7538RN/GDT7638RN */
#define PCI_DEVICE_ID_VORTEX_GDT7x58RN 0x16B /* GDT7558RN/GDT7658RN */
#endif

2008-08-03 03:02:56

by James Bottomley

Subject: Re: [PATCH] GDT SCSI DISK ARRAY: fix split line comments for grep

On Sun, 2008-08-03 at 08:44 +1000, Grant Coady wrote:
> Hi there,
>
> Following patch unsplits some comment lines that hold driver device
> names so they can be grepped.

I don't actually see a problem to be fixed here. The original author
obviously split the lines to be under 80 chars. The actual board names
are still integral in the comments and thus greppable even for the split
lines. What is it that you think needs to be fixed?

James

2008-08-03 03:40:18

by Grant Coady

Subject: Re: [PATCH] GDT SCSI DISK ARRAY: fix split line comments for grep

On Sat, 02 Aug 2008 22:00:21 -0500, James Bottomley <[email protected]> wrote:

>On Sun, 2008-08-03 at 08:44 +1000, Grant Coady wrote:
>> Hi there,
>>
>> Following patch unsplits some comment lines that hold driver device
>> names so they can be grepped.
>
>I don't actually see a problem to be fixed here. The original author
>obviously split the lines to be under 80 chars. The actual board names
>are still integral in the comments and thus greppable even for the split
>lines. What is it that you think needs to be fixed?

I suppose if you always grep with context there's no problem?

It's the only file I found with this issue while doing other stuff.

Grant.