2021-12-01 08:59:32

by Bixuan Cui

Subject: [PATCH -next] ALSA: oss: fix compile error when OSS_DEBUG is enabled

Fix compile error when OSS_DEBUG is enabled:
sound/core/oss/pcm_oss.c: In function 'snd_pcm_oss_set_trigger':
sound/core/oss/pcm_oss.c:2055:10: error: 'substream' undeclared (first
use in this function); did you mean 'csubstream'?
pcm_dbg(substream->pcm, "pcm_oss: trigger = 0x%x\n", trigger);
^

Fixes: 61efcee8608c ("ALSA: oss: Use standard printk helpers")
Signed-off-by: Bixuan Cui <[email protected]>
---
sound/core/oss/pcm_oss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c
index 82a8187..bb37665 100644
--- a/sound/core/oss/pcm_oss.c
+++ b/sound/core/oss/pcm_oss.c
@@ -2052,7 +2052,7 @@ static int snd_pcm_oss_set_trigger(struct snd_pcm_oss_file *pcm_oss_file, int tr
int err, cmd;

#ifdef OSS_DEBUG
- pcm_dbg(substream->pcm, "pcm_oss: trigger = 0x%x\n", trigger);
+ pr_debug("pcm_oss: trigger = 0x%x\n", trigger);
#endif

psubstream = pcm_oss_file->streams[SNDRV_PCM_STREAM_PLAYBACK];
--
1.8.3.1

2021-12-01 09:33:02

by Takashi Iwai

Subject: Re: [PATCH -next] ALSA: oss: fix compile error when OSS_DEBUG is enabled

On Wed, 01 Dec 2021 09:58:54 +0100,
Bixuan Cui wrote:
>
> Fix compile error when OSS_DEBUG is enabled:
> sound/core/oss/pcm_oss.c: In function 'snd_pcm_oss_set_trigger':
> sound/core/oss/pcm_oss.c:2055:10: error: 'substream' undeclared (first
> use in this function); did you mean 'csubstream'?
> pcm_dbg(substream->pcm, "pcm_oss: trigger = 0x%x\n", trigger);
> ^
>
> Fixes: 61efcee8608c ("ALSA: oss: Use standard printk helpers")
> Signed-off-by: Bixuan Cui <[email protected]>

Thanks, applied.


Takashi