2022-03-23 08:14:46

by Takashi Iwai

[permalink] [raw]
Subject: Re: An announcement for kernel-global workqueue users.

On Mon, 21 Mar 2022 02:24:23 +0100,
Tetsuo Handa wrote:
>
> Hello.
>
> The Linux kernel provides kernel-global WQs (namely, system_wq, system_highpri_wq,
> system_long_wq, system_unbound_wq, system_freezable_wq, system_power_efficient_wq
> and system_freezable_power_efficient_wq). But since attempt to flush kernel-global
> WQs has possibility of deadlock, Tejun Heo thinks that we should stop calling
> flush_scheduled_work() and flush_workqueue(system_*). Such callers as of Linux 5.17
> are listed below.
>
> ----------
> $ git grep -nF 'flush_scheduled_work()'
(snip)
> sound/soc/intel/atom/sst/sst.c:363: flush_scheduled_work();

At least this one looks superfluous, the call can be simply dropped.
I'm going to submit a fix patch.


thanks,

Takashi