2021-04-08 12:48:36

by Chen Huang

Subject: [PATCH -next] ALSA: virtio: use module_virtio_driver() to simplify the code

module_virtio_driver() makes the code simpler by eliminating
boilerplate code.

Signed-off-by: Chen Huang <[email protected]>
---
sound/virtio/virtio_card.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/sound/virtio/virtio_card.c b/sound/virtio/virtio_card.c
index ae9128063917..150ab3e37013 100644
--- a/sound/virtio/virtio_card.c
+++ b/sound/virtio/virtio_card.c
@@ -432,17 +432,7 @@ static struct virtio_driver virtsnd_driver = {
#endif
};

-static int __init init(void)
-{
- return register_virtio_driver(&virtsnd_driver);
-}
-module_init(init);
-
-static void __exit fini(void)
-{
- unregister_virtio_driver(&virtsnd_driver);
-}
-module_exit(fini);
+module_virtio_driver(virtsnd_driver);

MODULE_DEVICE_TABLE(virtio, id_table);
MODULE_DESCRIPTION("Virtio sound card driver");
--
2.17.1

2021-04-10 18:25:15

by Anton Yakovlev

Subject: Re: [PATCH -next] ALSA: virtio: use module_virtio_driver() to simplify the code

On 08.04.2021 14:54, Chen Huang wrote
>
> module_virtio_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Chen Huang <[email protected]>

Thanks for the patch.

Reviewed-by: Anton Yakovlev <[email protected]>

> ---
> sound/virtio/virtio_card.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/sound/virtio/virtio_card.c b/sound/virtio/virtio_card.c
> index ae9128063917..150ab3e37013 100644
> --- a/sound/virtio/virtio_card.c
> +++ b/sound/virtio/virtio_card.c
> @@ -432,17 +432,7 @@ static struct virtio_driver virtsnd_driver = {
> #endif
> };
>
> -static int __init init(void)
> -{
> - return register_virtio_driver(&virtsnd_driver);
> -}
> -module_init(init);
> -
> -static void __exit fini(void)
> -{
> - unregister_virtio_driver(&virtsnd_driver);
> -}
> -module_exit(fini);
> +module_virtio_driver(virtsnd_driver);
>
> MODULE_DEVICE_TABLE(virtio, id_table);
> MODULE_DESCRIPTION("Virtio sound card driver");
> --
> 2.17.1
>
>

2021-04-12 10:18:15

by Takashi Iwai

Subject: Re: [PATCH -next] ALSA: virtio: use module_virtio_driver() to simplify the code

On Thu, 08 Apr 2021 14:54:29 +0200,
Chen Huang wrote:
>
> module_virtio_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Chen Huang <[email protected]>

Thanks, applied now.


Takashi