2021-12-13 16:47:14

by Bradley Scott

Subject: [PATCH] ALSA: hda/realtek: Add new alc285-hp-amp-init model

Adds a new "alc285-hp-amp-init" model that can be used to apply the ALC285
HP speaker amplifier initialization fixup to devices that are not already
known by passing "hda_model=alc285-hp-amp-init" to the
snd-sof-intel-hda-common module or "model=alc285-hp-amp-init" to the
snd-hda-intel module, depending on which is being used.

Signed-off-by: Bradley Scott <[email protected]>
---
Documentation/sound/hd-audio/models.rst | 2 ++
sound/pci/hda/patch_realtek.c | 1 +
2 files changed, 3 insertions(+)

diff --git a/Documentation/sound/hd-audio/models.rst b/Documentation/sound/hd-audio/models.rst
index 0ea967d34583..d25335993e55 100644
--- a/Documentation/sound/hd-audio/models.rst
+++ b/Documentation/sound/hd-audio/models.rst
@@ -326,6 +326,8 @@ usi-headset
Headset support on USI machines
dual-codecs
Lenovo laptops with dual codecs
+alc285-hp-amp-init
+ HP laptops which require speaker amplifier initialization (ALC285)

ALC680
======
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index d162662fe684..fc41f3e8ddc3 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9124,6 +9124,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
{.id = ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP, .name = "alc287-ideapad-bass-spk-amp"},
{.id = ALC623_FIXUP_LENOVO_THINKSTATION_P340, .name = "alc623-lenovo-thinkstation-p340"},
{.id = ALC255_FIXUP_ACER_HEADPHONE_AND_MIC, .name = "alc255-acer-headphone-and-mic"},
+ {.id = ALC285_FIXUP_HP_GPIO_AMP_INIT, .name = "alc285-hp-amp-init"},
{}
};
#define ALC225_STANDARD_PINS \
--
2.25.1

2021-12-14 09:45:28

by Takashi Iwai

Subject: Re: [PATCH] ALSA: hda/realtek: Add new alc285-hp-amp-init model

On Mon, 13 Dec 2021 17:22:47 +0100,
Bradley Scott wrote:
>
> Adds a new "alc285-hp-amp-init" model that can be used to apply the ALC285
> HP speaker amplifier initialization fixup to devices that are not already
> known by passing "hda_model=alc285-hp-amp-init" to the
> snd-sof-intel-hda-common module or "model=alc285-hp-amp-init" to the
> snd-hda-intel module, depending on which is being used.
>
> Signed-off-by: Bradley Scott <[email protected]>

Thanks, applied now.


Takashi