2022-04-06 05:28:47

by Colin Ian King

Subject: [PATCH] ALSA: echoaudio: remove redundant assignment to variable i

The variable i is being assigned a value that is never read, it
is being re-assigned in the following for-loop. The assignment is
redundant and can be removed.

Signed-off-by: Colin Ian King <[email protected]>
---
sound/pci/echoaudio/midi.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/sound/pci/echoaudio/midi.c b/sound/pci/echoaudio/midi.c
index 7be5c3327b16..47b2c023ee3d 100644
--- a/sound/pci/echoaudio/midi.c
+++ b/sound/pci/echoaudio/midi.c
@@ -124,7 +124,6 @@ static int midi_service_irq(struct echoaudio *chip)
return 0;

/* Get the MIDI data from the comm page */
- i = 1;
received = 0;
for (i = 1; i <= count; i++) {
/* Get the MIDI byte */
--
2.35.1

2022-04-06 08:54:01

by Takashi Iwai

Subject: Re: [PATCH] ALSA: echoaudio: remove redundant assignment to variable i

On Tue, 05 Apr 2022 15:54:12 +0200,
Colin Ian King wrote:
>
> The variable i is being assigned a value that is never read, it
> is being re-assigned in the following for-loop. The assignment is
> redundant and can be removed.
>
> Signed-off-by: Colin Ian King <[email protected]>

Thanks, applied.


Takashi