2021-06-18 12:34:22

by Andy Chi

Subject: [PATCH v3 1/2] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8

From fdeab6f32dbdbfd83c9af6efc5a51f91021b6578 Mon Sep 17 00:00:00 2001
From: Andy Chi <[email protected]>
Date: Fri, 18 Jun 2021 16:17:48 +0800
Subject: [PATCH v3 1/2] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook
 450 G8

The HP ProBook 450 G8 using ALC236 codec which using 0x02 to
control mute LED and 0x01 to control micmute LED.
Therefore, add a quirk to make it works.

Signed-off-by: Andy Chi <[email protected]>
---
 v2 -> v3: no changes.
 v1 -> v2: fix typo from HP ProBook 440 to HP ProBook 450 G8 (https://lkml.org/lkml/2021/6/18/325)

 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index ab5113cccffa..70bc5b11acfd 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8336,6 +8336,7 @@ static const struct snd_pci_quirk
alc269_fixup_tbl[] = {
               ALC285_FIXUP_HP_GPIO_AMP_INIT),
     SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
     SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC",
ALC236_FIXUP_HP_GPIO_LED),
+    SND_PCI_QUIRK(0x103c, 0x87e7, "HP ProBook 450 G8 Notebook PC",
ALC236_FIXUP_HP_GPIO_LED),
     SND_PCI_QUIRK(0x103c, 0x87f2, "HP ProBook 640 G8 Notebook PC",
ALC236_FIXUP_HP_GPIO_LED),
     SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
     SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
-- 2.25.1

2021-06-18 17:25:54

by Takashi Iwai

Subject: Re: [PATCH v3 1/2] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8

On Fri, 18 Jun 2021 12:24:21 +0200,
Andy Chi wrote:
>
> >From fdeab6f32dbdbfd83c9af6efc5a51f91021b6578 Mon Sep 17 00:00:00 2001
> From: Andy Chi <[email protected]>
> Date: Fri, 18 Jun 2021 16:17:48 +0800
> Subject: [PATCH v3 1/2] ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook
>  450 G8

Still something wrong in your submission. e.g. the patch included the
bogus "From" line, and repeated From:, Date: and Subject: headers.
But, more badly...

> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index ab5113cccffa..70bc5b11acfd 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -8336,6 +8336,7 @@ static const struct snd_pci_quirk
> alc269_fixup_tbl[] = {

... the patch itself is inapplicable, it contains line breaks.
(e.g. the above should be a single line).

Try to submit via git-send-email. If it's difficult, just give via
attachments in the worst case.


thanks,

Takashi