Subject: [linux-2.6.0-test1] Missing #include lines with alsa at alpha


I've noticed that alsa_lib.c have missed afair #include linux/module.h
or init.h. Somebody is more oriented at this problem ? I've fixed it,
but i must test it, after that i can send the patch ;)

cheers

--
.----[ a d m i n at w o m b b dot e d u dot p l ]----.
| Przemys?aw Stanis?aw Knycz, [email protected] |
| Net/Sys Administrator, PLD Developer, RLU: 213344 |
`------ "Linux - the choice of GNU generation" ------'


2003-07-17 09:29:08

by Takashi Iwai

[permalink] [raw]
Subject: Re: [linux-2.6.0-test1] Missing #include lines with alsa at alpha

At Thu, 17 Jul 2003 09:24:32 +0200,
Przemys?aw Stanis?aw Knycz wrote:
>
>
> I've noticed that alsa_lib.c have missed afair #include linux/module.h
> or init.h. Somebody is more oriented at this problem ? I've fixed it,
> but i must test it, after that i can send the patch ;)

could you tell me which file exactly?


--
Takashi Iwai <[email protected]> SuSE Linux AG - http://www.suse.de
ALSA Developer ALSA Project - http://www.alsa-project.org

Subject: Re: [linux-2.6.0-test1] Missing #include lines with alsa at alpha

On Thu, Jul 17, 2003 at 11:43:59AM +0200, Takashi Iwai wrote:
> could you tell me which file exactly?

sound/
./pcmcia/vx/vxpocket.c
./pci/rme9652/hdsp.c
./drivers/opl4/opl4_lib.c

--- ./sound/pcmcia/vx/vxpocket.c~ 2003-07-14 05:31:21.000000000 +0200
+++ ./sound/pcmcia/vx/vxpocket.c 2003-07-16 22:06:22.000000000 +0200
@@ -35,6 +35,7 @@
#include <pcmcia/version.h>
#include "vxpocket.h"
#include <sound/initval.h>
+#include <linux/init.h>

/*
*/
--- ./sound/pci/rme9652/hdsp.c~ 2003-07-14 05:32:41.000000000 +0200
+++ ./sound/pci/rme9652/hdsp.c 2003-07-16 22:03:09.000000000 +0200
@@ -26,6 +26,7 @@
#include <linux/interrupt.h>
#include <linux/slab.h>
#include <linux/pci.h>
+#include <linux/init.h>

#include <sound/core.h>
#include <sound/control.h>
--- ./sound/drivers/opl4/opl4_lib.c~ 2003-07-17 22:07:25.000000000 +0200
+++ ./sound/drivers/opl4/opl4_lib.c 2003-07-17 22:15:24.000000000 +0200
@@ -21,6 +21,7 @@
#include <sound/initval.h>
#include <linux/ioport.h>
#include <asm/io.h>
+#include <linux/init.h>

MODULE_AUTHOR("Clemens Ladisch <[email protected]>");
MODULE_DESCRIPTION("OPL4 driver");


This patches allow to build it without problems. Happy bugtracking :)

--
.----[ a d m i n at w o m b b dot e d u dot p l ]----.
| Przemys?aw Stanis?aw Knycz, Registered Linux User |
| Net/Sys Administrator, PLD Developer, 213344 |
`------ "Linux - the choice of GNU generation" ------'

2003-07-18 09:54:45

by Takashi Iwai

[permalink] [raw]
Subject: Re: [linux-2.6.0-test1] Missing #include lines with alsa at alpha

At Thu, 17 Jul 2003 22:36:56 +0200,
Przemys?aw Stanis?aw Knycz wrote:
>
> On Thu, Jul 17, 2003 at 11:43:59AM +0200, Takashi Iwai wrote:
> > could you tell me which file exactly?
>
> sound/
> ./pcmcia/vx/vxpocket.c
> ./pci/rme9652/hdsp.c
> ./drivers/opl4/opl4_lib.c

thanks, i fixed the ALSA cvs.
the patchset will be submitted later...


Takashi